Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authors / RSS Widget: improve layout for Twenty Nineteen #10522

Closed
jeherve opened this issue Nov 2, 2018 · 4 comments
Closed

Authors / RSS Widget: improve layout for Twenty Nineteen #10522

jeherve opened this issue Nov 2, 2018 · 4 comments
Assignees
@allancole @crunnells
Labels
[Feature] Extra Sidebar Widgets [Feature] Theme Tools [Type] Bug When a feature is broken and / or not performing as intended
Milestone
6.8

Comments

@jeherve
Copy link
Member

jeherve commented Nov 2, 2018

  1. Add the Twenty Nineteen theme to your site.
  2. Add both the Authors widget and the RSS widget to the sidebar:

9s1prkliia

0fl589sxdv 1

I think the bullets don’t make much sense in this theme – I don’t see them in any other widget. Perhaps we should just remove them and the space that they introduce?
Same for the RSS widget
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Feature] Theme Tools labels Nov 2, 2018
@jeherve jeherve added this to the 6.8 milestone Nov 2, 2018
@jeherve jeherve mentioned this issue Nov 2, 2018
Closed
10 tasks
@allancole
Copy link
Contributor

I think the bullets don’t make much sense in this theme – I don’t see them in any other widget. Perhaps we should just remove them and the space that they introduce? Same for the RSS widget

While there might not be other widgets that use bullets for lists, bullets do appear in the List Block (and in normal lists from the old editor). Screenshot:

image

@allancole
Copy link
Contributor

I think the appearance for these should look as close as possible to comments with avatars:

image

crunnells added a commit that referenced this issue Nov 7, 2018
@crunnells
Fix Twenty Nineteen Authors and RSS Links widget styles
657bc6f 
Fixes #10522 and brings widget author style in line with comment author styles
@crunnells
Copy link
Contributor

This issue should be fixed by the above commit, pending review by @allancole

@jeherve jeherve modified the milestones: 6.8, 6.7.1 Nov 8, 2018
@allancole
Copy link
Contributor

Yup, this is looking great, @crunnells. Thanks!

@jeherve jeherve mentioned this issue Nov 9, 2018
Merged
jeherve added a commit that referenced this issue Nov 9, 2018
@jeherve
Twenty Nineteen: second round of compat fixes for Jetpack widgets (#1…
876f1e2 
…0579)

* Update Twenty Nineteen styling of EU cookie widget

This addresses #10513

* Fix Twenty Nineteen Authors and RSS Links widget styles

Fixes #10522 and brings widget author style in line with comment author styles
jeherve added a commit that referenced this issue Nov 9, 2018
@jeherve
Twenty Nineteen: second round of compat fixes for Jetpack widgets (#1…
7974064 
…0579)

* Update Twenty Nineteen styling of EU cookie widget

This addresses #10513

* Fix Twenty Nineteen Authors and RSS Links widget styles

Fixes #10522 and brings widget author style in line with comment author styles
@jeherve jeherve modified the milestones: 6.7.1, 6.8 Nov 22, 2018
@aninax aninax mentioned this issue Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allancole allancole

@crunnells crunnells

Labels
[Feature] Extra Sidebar Widgets [Feature] Theme Tools [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.8
Development

No branches or pull requests
3 participants
@jeherve @allancole @crunnells