Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twenty Nineteen: second round of compat fixes for Jetpack widgets #10579

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Twenty Nineteen: second round of compat fixes for Jetpack widgets #10579

merged 2 commits into from
Nov 9, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 9, 2018 •
edited
Loading

Fixes #10335
Fixes #10513
Fixes #10522

Changes proposed in this Pull Request:

More changes to the style of some Jetpack widgets when used with the new Twenty Nineteen theme.

This PR focuses on 3 widgets:

  • The Authors widget
  • The RSS widget
  • The Cookies and Consents Widget

Testing instructions:

  • Start by downloading the latest version of the theme from here. Unzip it, rename the folder to twentynineteen, rezip it, then upload and activate it on your site.
  • Add the 3 widgets mentioned above to your sidebar.
  • Make sure they look good.

Proposed changelog entry for your changes:

  • Twenty Nineteen: ensure compatibility with Jetpack's widgets.

@crunnells
Update Twenty Nineteen styling of EU cookie widget
7f74fd9 
This addresses #10513
@crunnells
Fix Twenty Nineteen Authors and RSS Links widget styles
657bc6f 
Fixes #10522 and brings widget author style in line with comment author styles
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Theme Tools [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 9, 2018
@jeherve jeherve added this to the 6.7.1 milestone Nov 9, 2018
@jeherve jeherve requested review from allancole and a team November 9, 2018 07:21
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 4, 2018.
Scheduled code freeze: November 27, 2018

Generated by 🚫 dangerJS

jeherve
jeherve commented Nov 9, 2018
View reviewed changes
Copy link
Member Author

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well on my end. 👍

oskosk
oskosk approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on WP 5.0 Beta 3 with Twenty Nineteen, Jetpack connected, and looks good to me!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 9, 2018
jeherve added a commit that referenced this pull request Nov 9, 2018
@jeherve
changelog: add #10579
b8e8610
@jeherve jeherve merged commit 876f1e2 into master Nov 9, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 9, 2018
@jeherve jeherve deleted the add/twentynineteen-compat-v2 branch November 9, 2018 16:16
jeherve added a commit that referenced this pull request Nov 9, 2018
@jeherve
Twenty Nineteen: second round of compat fixes for Jetpack widgets (#1…
7974064 
…0579)

* Update Twenty Nineteen styling of EU cookie widget

This addresses #10513

* Fix Twenty Nineteen Authors and RSS Links widget styles

Fixes #10522 and brings widget author style in line with comment author styles
@jeherve
Copy link
Member Author

jeherve commented Nov 9, 2018

Cherry-picked to branch-6.7 in 7974064

jeherve added a commit that referenced this pull request Nov 9, 2018
@jeherve
Changelog: prep for 6.7.1 (#10576)
aa8a222 
* Changelog: prepare for the next release.

* changelog: prep for 6.7.1

* Changelog: add #10566

* changelog: add testing list.

* changelog: add #10579
jeherve added a commit that referenced this pull request Nov 9, 2018
@jeherve
Changelog: prep for 6.7.1 (#10576)
11a40ab 
* Changelog: prepare for the next release.

* changelog: prep for 6.7.1

* Changelog: add #10566

* changelog: add testing list.

* changelog: add #10579
@jeherve jeherve modified the milestones: 6.7.1, 6.8 Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

@allancole allancole Awaiting requested review from allancole

Assignees

@crunnells crunnells

Labels
[Feature] Theme Tools [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @oskosk @crunnells @matticbot