Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related Posts / Twenty Nineteen: layout issues #10585

Closed
jeherve opened this issue Nov 9, 2018 · 1 comment · Fixed by #10589
Closed

Related Posts / Twenty Nineteen: layout issues #10585

jeherve opened this issue Nov 9, 2018 · 1 comment · Fixed by #10589
Assignees
@allancole @crunnells
Labels
[Feature] Related Posts [Feature] Theme Tools [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Milestone
6.8

Comments

@jeherve
Copy link
Member

jeherve commented Nov 9, 2018

Steps to reproduce the issue

I tested Related Posts in Chrome, on a site using the most recent version of Jetpack (master). I am seeing some layout issues in some areas:

  1. Under Appearance > Customize

screenshot 2018-11-09 at 13 12 21

-> Notice the alignment issue as well as the font size and heading font size issue.
  1. On the frontend of the site:

screenshot 2018-11-09 at 13 36 15

-> Notice the alignment issue as well as the font size and heading font size issue.
  1. On a site using an RTL language, however, things look better:

screenshot 2018-11-09 at 13 37 11

The headings, however, are smaller.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Theme Tools [Feature] Related Posts [Pri] BLOCKER labels Nov 9, 2018
@jeherve jeherve added this to the 6.7.1 milestone Nov 9, 2018
@jeherve jeherve changed the title Related Posts / Twenty Nineteen Related Posts / Twenty Nineteen: layout issues Nov 9, 2018
@jeherve jeherve mentioned this issue Nov 9, 2018
Closed
10 tasks
@jeherve
Copy link
Member Author

jeherve commented Nov 9, 2018

cc @allancole @crunnells I spotted a few more issues that it would be nice to fix.

This was referenced Nov 9, 2018
Merged
Merged
@jeherve jeherve modified the milestones: 6.7.1, 6.8 Nov 15, 2018
jeherve pushed a commit that referenced this issue Nov 15, 2018
@allancole @jeherve
Fix module layout issues with Twenty Nineteen theme (#10589)
309382c 
<!--- Provide a general summary of your changes in the Title above -->

Fixes #10585
Fixes #10587

#### Changes proposed in this Pull Request:
<!--- Explain what functional changes your PR includes -->

- [x] Removes margin styles from Related Posts module, Recipe shortcodes and Presentation shortcodes.
- [x] Layout margin styles now come from the theme to prevent layout issues with other plugins. See: WordPress/twentynineteen#502 and WordPress/twentynineteen#534
- [x] Also remove margin styles from Akismet privacy notice since it also gets fixed by the theme here: WordPress/twentynineteen#533

#### Testing instructions:
<!-- Please include detailed testing steps, explaining how to test your change. -->
<!-- Bear in mind that context you working on is not obvious for everyone.  -->
<!-- Adding "simple" configuration steps will help reviewers to get to your PR as quickly as possible. -->
<!-- "Before / After" screenshots can also be very helpful when the change is visual. -->

* Test the Recipe or Presentation shortcode with the latest version of Twenty Nineteen: https://github.com/WordPress/twentynineteen/
* Test the layout against the Akismet notice with the latest version of Twenty Nineteen: https://github.com/WordPress/twentynineteen/

#### Proposed changelog entry for your changes:
<!-- Please do not leave this empty. If no changelog entry needed, state as such. -->

* Fix layout issues in Jetpack modules and shortcodes for Twenty Nineteen theme
jeherve pushed a commit that referenced this issue Nov 15, 2018
@allancole @jeherve
Fix module layout issues with Twenty Nineteen theme (#10589)
8121cb4 
<!--- Provide a general summary of your changes in the Title above -->

Fixes #10585
Fixes #10587

#### Changes proposed in this Pull Request:
<!--- Explain what functional changes your PR includes -->

- [x] Removes margin styles from Related Posts module, Recipe shortcodes and Presentation shortcodes.
- [x] Layout margin styles now come from the theme to prevent layout issues with other plugins. See: WordPress/twentynineteen#502 and WordPress/twentynineteen#534
- [x] Also remove margin styles from Akismet privacy notice since it also gets fixed by the theme here: WordPress/twentynineteen#533

#### Testing instructions:
<!-- Please include detailed testing steps, explaining how to test your change. -->
<!-- Bear in mind that context you working on is not obvious for everyone.  -->
<!-- Adding "simple" configuration steps will help reviewers to get to your PR as quickly as possible. -->
<!-- "Before / After" screenshots can also be very helpful when the change is visual. -->

* Test the Recipe or Presentation shortcode with the latest version of Twenty Nineteen: https://github.com/WordPress/twentynineteen/
* Test the layout against the Akismet notice with the latest version of Twenty Nineteen: https://github.com/WordPress/twentynineteen/

#### Proposed changelog entry for your changes:
<!-- Please do not leave this empty. If no changelog entry needed, state as such. -->

* Fix layout issues in Jetpack modules and shortcodes for Twenty Nineteen theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allancole allancole

@crunnells crunnells

Labels
[Feature] Related Posts [Feature] Theme Tools [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.8
Development

Successfully merging a pull request may close this issue.

Fix module layout issues with Twenty Nineteen theme Automattic/jetpack
3 participants
@jeherve @allancole @crunnells