Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes typography issues with Related Posts module #10586

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Fixes typography issues with Related Posts module #10586

merged 3 commits into from
Nov 13, 2018

Conversation

allancole
Copy link
Contributor

@allancole allancole commented Nov 9, 2018 •
edited
Loading

Addresses typographic issues in #10585

Changes proposed in this Pull Request:

  • Adds fonts and fonts-sizes for Related Post module title, post-titles, and post meta based on theme design.
  • Also replaces .hentry with .entry selectors to prevent unexpected theme overrides (theme now uses .entry and so should Jetpack).

Testing instructions:

Proposed changelog entry for your changes:

  • Fix typography issues with Related Posts module

@allancole allancole added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Theme Tools [Feature] Related Posts labels Nov 9, 2018
@allancole allancole requested review from a team and jeherve November 9, 2018 17:26
@jetpackbot
Copy link

jetpackbot commented Nov 9, 2018 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 4, 2018.
Scheduled code freeze: November 27, 2018

Generated by 🚫 dangerJS

@allancole allancole added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 9, 2018
@jeherve jeherve added this to the 6.7.1 milestone Nov 9, 2018
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 9, 2018
jeherve
jeherve approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in my tests. 🚢

@jeherve jeherve merged commit 05edddd into master Nov 13, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 13, 2018
@jeherve jeherve deleted the fix/related-posts-for-twentynineteen branch November 13, 2018 00:11
jeherve pushed a commit that referenced this pull request Nov 13, 2018
@allancole @jeherve
Fixes typography issues with Related Posts module (#10586)
747d705 
* Fixes typography issues with Related Posts module

* Adds typographic tweaks for grid, list, thumbnail, show-date, show-context settings

* Revert font-size change to keep hidden text hidden
@jeherve
Copy link
Member

jeherve commented Nov 13, 2018

Cherry-picked to branch-6.7 in 747d705

@jeherve jeherve modified the milestones: 6.7.1, 6.8 Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@allancole allancole

Labels
[Feature] Related Posts [Feature] Theme Tools [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
4 participants
@allancole @jetpackbot @jeherve @matticbot