Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Add headers to each section to explain each section's theme #10688

Closed
joanrho opened this issue Nov 21, 2018 · 4 comments
Closed

Settings: Add headers to each section to explain each section's theme #10688

joanrho opened this issue Nov 21, 2018 · 4 comments
Assignees
@keoshi
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@joanrho
Copy link
Contributor

joanrho commented Nov 21, 2018 •
edited by jeherve
Loading

The entire settings sections don’t have headers that explain why users should care about something like ‘Writing enhancements’. Let's add headers that help explain the theme of the settings below.

ref: p6TEKc-2m8-p2 (RB / item 5.13)
@joanrho joanrho added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Admin Page React-powered dashboard under the Jetpack menu labels Nov 21, 2018
@jeffgolenski
Copy link
Member

related project: https://github.com/orgs/Automattic/projects/28

@joanrho joanrho mentioned this issue Dec 6, 2018
Closed
@jeffgolenski
Copy link
Member

@joanrho Are you thinking of something like this for each section?

screen shot 2018-12-07 at 1 48 58 pm

@joanrho
Copy link
Contributor Author

joanrho commented Dec 7, 2018

@jeffgolenski Yes, that looks perfect! Thank u, Jeff.

@joanrho joanrho removed their assignment Dec 7, 2018
@keoshi
Copy link
Contributor

keoshi commented Dec 10, 2018

@joanrho I searched around and doesn't seem like we have copy for these yet. Did you start a Gdoc, or should I come up with something and ping Editorial for input? Thanks!

@keoshi keoshi assigned keoshi and unassigned jeffgolenski Dec 10, 2018
@keoshi keoshi mentioned this issue Dec 11, 2018
Merged
jeherve pushed a commit that referenced this issue Dec 13, 2018
@keoshi @jeherve
Settings: add descriptions to settings sections (#10940)
bc56ba4 
Fixes #10688

#### Changes proposed in this Pull Request:

* Adds descriptions to all settings sections headers explaining the theme of the options below.
* Cleans up dependencies paths on `settings/index.jsx`.

![image](https://user-images.githubusercontent.com/390760/49929419-606e1780-feba-11e8-82e2-8da1b914524a.png)

#### Testing instructions:

* Fire up this PR.
* Go to Jetpack settings.
* Read the descriptions on each section.

#### Proposed changelog entry for your changes:

* Settings: add descriptions to settings sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keoshi keoshi

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joanrho @jeffgolenski @keoshi