-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: create a new settings tab for performance #10550
Comments
@rickybanister can you clarify what you mean by the acronym "WPSC" in your comment above? |
Note: This issues changes a large section of Jetpack's IA. we'll have to be strategic for updating this across our various jetpack platforms. A "performance" section doesn't currently exist. We'll be grabbing sections from other areas and adding them altogether, here. *** BEFORE *** *** AFTER *** wp-admin Jetpack Free & Professional views Calypso Jetpack Free & Professional views Mobile cc @joanrho @keoshi @rickybanister @iamthomasbishop @SylvesterWilmott |
@rickybanister There's a lot to going on here, I'd like to consider breaking these two into different issues:
Love that idea, but we should do it for all of the tabs - which I think we explored at one point. After we get this hefty issue tackled we can do that one.
This would be great for all settings areas as well. |
Thanks for sharing the mocks, @jeffgolenski! The new "Performance" section looks great. Few Qs:
|
@jeffgolenski WPSC is WP Super Cache, the caching plugin we maintain. |
@jeffgolenski I would have a few questions about the wp-admin part:
Thank you! |
@jeherve Thanks for the follow up! Here are some answers for you...
Thanks Jer! |
As mentioned above. Bumping AMP and WPSC to another issues so we can focus on the core part of this issue: #10994 |
- See #10550 - Move existing cards over to a new "Performance" section.
Thank you! This should now be ready for review: #10941 |
@joanrho Sorry I missed your questions!
The general tab has never existed within the Jetpack dash inside /wp-admin/. Only in calypso. It will remain there in calypso, "performance" will come right after it.
Yessa. I took this on before that issue. ✔️
My guess is that @rickybanister means at the top of each section there would be a "master switch" to enable every feature in said category. Example: On the performance tab, up at the top near the the description, there would be a card with a toggle that would say "Enable all performance features," or something? |
Issues for |
Fixes #10550 #### Changes proposed in this Pull Request: This PR moves existing cards over to a new "Performance" section in Jetpack settings, and makes that "Performance" tab the new default tab you see when heading to Jetpack > Settings in your dashboard. ![image](https://user-images.githubusercontent.com/426388/50154173-d4e4f400-02c8-11e9-80dc-1ba5678c4df0.png) #### Testing instructions: * Go to Jetpack > Settings * Make sure all settings work, including the new Performance section. #### Proposed changelog entry for your changes: * Jetpack Dashboard: add a new "Performance" section
@jeffgolenski @rickybanister thanks for clarifying! I love the idea of a "turn everything on" type of turbo boost master switch (😂) for each section in settings, but let's shelve that idea for improved onboarding. I'll open a separate issue for that so we don't forget. |
This issue is a placeholder to discuss creating a new tab in settings for Performance-related features like image and file CDN, lazy load, AMP (just a promotion), WPSC (just a promotion), and so forth.
The tab would want to have a pre-amble at the top explaining our performance options and perhaps piloting an autopilot or turbo booster master switch.
The text was updated successfully, but these errors were encountered: