Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: create a new settings tab for performance #10550

Closed
rickybanister opened this issue Nov 6, 2018 · 12 comments
Closed

Settings: create a new settings tab for performance #10550

rickybanister opened this issue Nov 6, 2018 · 12 comments
Assignees
Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] Performance [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@rickybanister
Copy link

This issue is a placeholder to discuss creating a new tab in settings for Performance-related features like image and file CDN, lazy load, AMP (just a promotion), WPSC (just a promotion), and so forth.

The tab would want to have a pre-amble at the top explaining our performance options and perhaps piloting an autopilot or turbo booster master switch.

@rickybanister rickybanister added [Focus] Performance [Status] Needs Design Review Design has been added. Needs a review! labels Nov 6, 2018
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Admin Page React-powered dashboard under the Jetpack menu labels Nov 6, 2018
@joanrho joanrho self-assigned this Dec 3, 2018
@jeffgolenski jeffgolenski assigned jeffgolenski and unassigned joanrho Dec 3, 2018
@jeffgolenski
Copy link
Member

@rickybanister can you clarify what you mean by the acronym "WPSC" in your comment above?

@jeffgolenski
Copy link
Member

Note: This issues changes a large section of Jetpack's IA. we'll have to be strategic for updating this across our various jetpack platforms.

A "performance" section doesn't currently exist. We'll be grabbing sections from other areas and adding them altogether, here.

*** BEFORE ***

wp-admin
screen shot 2018-12-06 at 2 05 57 pm

Calypso
screen shot 2018-12-06 at 2 05 32 pm

Mobile
photo dec 06 13 44 05

*** AFTER ***

wp-admin

Jetpack Free & Professional views

jetpack free - wp-admin
jetpack pro - wp-admin

Calypso

Jetpack Free & Professional views

jetpack free - calypso
jetpack pro - calypso

Mobile

mobile - after

cc @joanrho @keoshi @rickybanister @iamthomasbishop @SylvesterWilmott

@jeffgolenski
Copy link
Member

@rickybanister There's a lot to going on here, I'd like to consider breaking these two into different issues:

  1. The tab would want to have a pre-amble at the top explaining our performance options

Love that idea, but we should do it for all of the tabs - which I think we explored at one point. After we get this hefty issue tackled we can do that one.

  1. piloting an autopilot or turbo booster master switch.

This would be great for all settings areas as well.

@joanrho
Copy link
Contributor

joanrho commented Dec 6, 2018

Thanks for sharing the mocks, @jeffgolenski! The new "Performance" section looks great. Few Qs:

  1. What happened to the "General" tab?
  2. In response to your numero uno pre-amble mention above, this already exists as an open issue (Settings: Add headers to each section to explain each section's theme #10688) so you don't need to create a new one. We'll tackle all of them at once with Editorial's assistance.
  3. What exactly do you mean by "piloting an autopilot or turbo booster master switch"? Sounds cool but i don't fully understand it...

@rickybanister
Copy link
Author

@jeffgolenski WPSC is WP Super Cache, the caching plugin we maintain.

@jeherve
Copy link
Member

jeherve commented Dec 11, 2018

@jeffgolenski I would have a few questions about the wp-admin part:

  • On your mockup the new "Performance" tab is the first. Until now the Writing tab was first and appeared as the default tab when someone would access wp-admin/admin.php?page=jetpack#/settings. Should we change it to Performance now?
  • The AMP prompt is new. Could you give me more details about this?
    • The wording I should use.
    • The different states (AMP uninstalled, AMP installed)
    • Should it appear in development mode as well?
    • Where the link should bring us (I was thinking about wp-admin/plugin-install.php?s=amp&tab=search&type=term, but the first result there is not our plugin. We could load it in Calypso, at https://wordpress.com/plugins/amp/siteurl, but then we would have to provide a different link when in dev mode)

Thank you!

@keoshi keoshi removed the [Status] Needs Design Review Design has been added. Needs a review! label Dec 14, 2018
@jeffgolenski
Copy link
Member

@jeherve Thanks for the follow up! Here are some answers for you...

  1. Yes - let's give Performance a shot at being the first item listed in the settings navigation. We can restructure it later if we need to, but I think there's more value to show to customers there, than the writing tab at this point.

  2. For the sake of time, let's forgo adding AMP to this area (same goes for WP Super Cache rick mentioned above as well). That prompt currently exists in the calypso UI. But I think we should spend a little more time about thinking how to add it to the context of the wp-admin. I'll create a new issue for that.

Thanks Jer!

@jeffgolenski
Copy link
Member

As mentioned above. Bumping AMP and WPSC to another issues so we can focus on the core part of this issue: #10994

jeherve added a commit that referenced this issue Dec 18, 2018
- See #10550
- Move existing cards over to a new "Performance" section.
@jeherve
Copy link
Member

jeherve commented Dec 18, 2018

Thank you! This should now be ready for review: #10941

@jeffgolenski
Copy link
Member

@joanrho Sorry I missed your questions!

What happened to the "General" tab?

The general tab has never existed within the Jetpack dash inside /wp-admin/. Only in calypso. It will remain there in calypso, "performance" will come right after it.

In response to your numero uno pre-amble mention above, this already exists as an open issue (#10688) so you don't need to create a new one. We'll tackle all of them at once with Editorial's assistance.

Yessa. I took this on before that issue. ✔️

What exactly do you mean by "piloting an autopilot or turbo booster master switch"? Sounds cool but i don't fully understand it...

My guess is that @rickybanister means at the top of each section there would be a "master switch" to enable every feature in said category. Example: On the performance tab, up at the top near the the description, there would be a card with a toggle that would say "Enable all performance features," or something?

@jeffgolenski
Copy link
Member

jeffgolenski commented Dec 18, 2018

Issues for
Calypso: Automattic/wp-calypso#29545
Mobile: p4a5px-2jI-p2

jeherve added a commit that referenced this issue Dec 18, 2018
Fixes #10550

#### Changes proposed in this Pull Request:

This PR moves existing cards over to a new "Performance" section in Jetpack settings, and makes that "Performance" tab the new default tab you see when heading to Jetpack > Settings in your dashboard.

![image](https://user-images.githubusercontent.com/426388/50154173-d4e4f400-02c8-11e9-80dc-1ba5678c4df0.png)


#### Testing instructions:

* Go to Jetpack > Settings
* Make sure all settings work, including the new Performance section.

#### Proposed changelog entry for your changes:

* Jetpack Dashboard: add a new "Performance" section
@joanrho
Copy link
Contributor

joanrho commented Dec 18, 2018

@jeffgolenski @rickybanister thanks for clarifying! I love the idea of a "turn everything on" type of turbo boost master switch (😂) for each section in settings, but let's shelve that idea for improved onboarding. I'll open a separate issue for that so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] Performance [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

5 participants