Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: ensure compatibility with spread operator changes in WP 5.3 #13694

Closed
jeherve opened this issue Oct 9, 2019 · 1 comment · Fixed by #13695
Closed

API: ensure compatibility with spread operator changes in WP 5.3 #13694

jeherve opened this issue Oct 9, 2019 · 1 comment · Fixed by #13695
Assignees
@jeherve
Labels
[Feature] WPCOM API [Pri] High [Type] Janitorial
Milestone
7.9

Comments

@jeherve
Copy link
Member

jeherve commented Oct 9, 2019

if your plugin/theme is one of the limited number of plugins and themes which extends one of the below listed classes and overloads any of the listed methods, you will need to take action.
-- https://make.wordpress.org/core/2019/10/09/wp-5-3-introducing-the-spread-operator/

Master issue: #13597
@jeherve jeherve added this to the 7.9 milestone Oct 9, 2019
@jeherve
Copy link
Member Author

jeherve commented Oct 9, 2019 •
edited
Loading

As far as I can tell we're only extending Automatic_Upgrader_Skin on that list.

@jeherve jeherve mentioned this issue Oct 9, 2019
Closed
11 tasks
@jeherve jeherve self-assigned this Oct 9, 2019
jeherve added a commit that referenced this issue Oct 9, 2019
@jeherve
General: bring in changes introduced in WordPress 5.3
e142037 
Fixes #13694

See https://make.wordpress.org/core/2019/10/09/wp-5-3-introducing-the-spread-operator/
@jeherve jeherve mentioned this issue Oct 9, 2019
Merged
jeherve added a commit that referenced this issue Oct 11, 2019
@jeherve
General: bring in changes introduced in WordPress 5.3 (#13695)
260f8d4 
Fixes #13694

See https://make.wordpress.org/core/2019/10/09/wp-5-3-introducing-the-spread-operator/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] WPCOM API [Pri] High [Type] Janitorial
Projects
None yet
Milestone
7.9
Development

Successfully merging a pull request may close this issue.

General: bring in changes introduced in WordPress 5.3 Automattic/jetpack
1 participant
@jeherve