Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Dashboard, Instant Search, Blocks broken in IE11 #14273

Closed
jeherve opened this issue Dec 20, 2019 · 7 comments · Fixed by #14194
Closed

Build: Dashboard, Instant Search, Blocks broken in IE11 #14273

jeherve opened this issue Dec 20, 2019 · 7 comments · Fixed by #14194
Assignees
@jsnajdr
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Search For all things related to Search [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.2

Comments

@jeherve
Copy link
Member

jeherve commented Dec 20, 2019

Originally reported in 4578-gh-jpop-issues

All our bundles are currently broken in IE11, as more and more of our dependencies we rely on use ES6, which can't be used in IE11.

There are different ways to solve that problem.

In the past, we have made an exception and transpiled modules that shipped with ES6:
#12511
#12541

Calypso does that for multiple modules:
https://github.com/Automattic/wp-calypso/blob/5d143f1e7f4d96ddf833db4e0c42c0598d9406aa/webpack.config.js#L126

A potential solution that would work for everyone could be to rely on calypso-build to do that work for us:
Automattic/wp-calypso#33496
Automattic/wp-calypso#33492
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended Admin Page React-powered dashboard under the Jetpack menu [Pri] High [Feature] Search For all things related to Search Instant Search labels Dec 20, 2019
@mmtr mmtr mentioned this issue Dec 27, 2019
Merged
@jeherve jeherve mentioned this issue Jan 8, 2020
Merged
@ockham
Copy link
Contributor

ockham commented Jan 17, 2020

@jsnajdr recently merged Automattic/wp-calypso#38531 -- an update to calypso-build v6 might thus fix the issue.

@jeherve
Copy link
Member Author

jeherve commented Jan 17, 2020

Yep, waiting on Renovate to hit us up with a PR soon :)

@jeherve jeherve added this to the 8.2 milestone Jan 17, 2020
@simison
Copy link
Member

simison commented Jan 17, 2020 •
edited
Loading

Not sure why Renovate isn't updating this PR even if it's been some time since calypso-build v6.0.0 update: #14194

Update: Oh! Renovate works only during weekends 😀

jetpack/.github/renovate.json

Line 7 in 03212a4

"schedule": [ "every weekend" ],

@jeherve
Copy link
Member Author

jeherve commented Jan 20, 2020

I can't seem to build Jetpack with Calypso Build 6.0.0:

Message:
    Module build failed (from ./node_modules/@automattic/calypso-build/node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
[BABEL] wp-content/plugins/jetpack/node_modules/@automattic/format-currency/node_modules/debug/src/browser.js: Cannot find module '@babel/plugin-transform-runtime' from 'wp-content/plugins/jetpack'

@simison
Copy link
Member

simison commented Jan 20, 2020

can't seem to build Jetpack with Calypso Build 6.0.0:

I think both @blowery and @jsnajdr are AFK today but I'll ping 'em anyway 😁

@renovate renovate bot mentioned this issue Jan 20, 2020
Merged
1 task
@simison
Copy link
Member

simison commented Jan 20, 2020

Blocks & Search bundles were mentioned fixed.

Did the Jetpack dashboard also get fixed?

@jeherve
Copy link
Member Author

jeherve commented Jan 20, 2020

Did the Jetpack dashboard also get fixed?

Yes, it works well in IE11 in my test.

@mmtr mmtr mentioned this issue Mar 25, 2020
Merged
mmtr added a commit to Automattic/wp-calypso that referenced this issue Mar 26, 2020
@mmtr
E2E: Add back "can update homepage" step to signup tests (#40432)
6472e09 
Brings back the "can update homepage" step to the signup E2E tests (removed in #40391) with a few amendments:

- D40692-code added a new task to the top of the checklist, so the "Update your homepage" task is no longer open by default. The signup tests open now that task before trying to update the homepage from "My Home".
- Block editor is closed after performing the checks to ensure that next steps ("can delete the plan"/"can delete our newly created account") don't fail because the masterbar is not present. This needed to initialize the editor in order to dismiss the welcome guide modal and make the close button clickable. Note that the close button is not displayed on mobile, so on such devices we just navigate back.
- Invalid blocks are checked in IE11 now that Jetpack blocks are working again (Automattic/jetpack#14273).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsnajdr jsnajdr

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Search For all things related to Search [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.2
Development

Successfully merging a pull request may close this issue.

Update dependency @automattic/calypso-build to v6.0.0 Automattic/jetpack
4 participants
@simison @ockham @jeherve @jsnajdr