Vimeo Shortcode Embed: Broken Formatting after Recent Update #14279
Assignees
Labels
Customer Report
Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report"
[Feature] Shortcodes / Embeds
[Type] Bug
When a feature is broken and / or not performing as intended
Milestone
Comments
JoshuaGoode
added
[Type] Bug
jeherve
added a commit
that referenced
this issue
Jan 21, 2020
Fixes #14279 We previously only supported 2 main shortcode formats: - the old format (w=350&h=500) that relies on shorthand for width and height (w and h), with all shortcode attributes in one string separated by & - the new format (width=350 height=500) that relies on the full words However our implementation unofficially supported a third, mixed format, with the w and h shorthand supported in the new format. This commit makes that third format official.
jeherve
added a commit
that referenced
this issue
Jan 22, 2020
* Vimeo: add new shortcode format Fixes #14279 We previously only supported 2 main shortcode formats: - the old format (w=350&h=500) that relies on shorthand for width and height (w and h), with all shortcode attributes in one string separated by & - the new format (width=350 height=500) that relies on the full words However our implementation unofficially supported a third, mixed format, with the w and h shorthand supported in the new format. This commit makes that third format official. * Vimeo: add test for new supported shortcode format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Vimeo Shortcode Embed: Broken Formatting after Recent Update
Currently encountering an issue with Vimeo shortcode embeds.
Some users seemed to have added Vimeo shortcode embeds like
[vimeo 368043020 w=640 h=360]instead of the recommended format[vimeo 368043020 w=640&h=360]This worked, or appeared to work without breaking, up until very recently and now is causing issues such as excessive height or very small videos.
In most cases, it will cause excessive height making it look like extra padding above the video. If using a theme like Dicot, it will cause the video to be small.
I've currently reproduced on self-hosted, WordPress.com Business with plugins. It seems to be working fine on non-Business or eCommerce plan WordPress.com sites. During a support session, I found that this is impacting a site that that has up to 1000+ posts with videos entered in that format that had been working.
Possibly related to the recent changes in Migrate the vimeo shortcode AMP logic to Jetpack from the AMP plugin #13921
Internal discussion with site examples: p1577380715003600-slack-jetpack-plugin
Related internal ticket: 2585915-zen
Steps to reproduce the issue
[vimeo 368043020 w=640 h=360]without an & between the dimensions.An example of the HTML generated for the iframe. Note that the width isn't being honored and the excessive height being set.
What I expected
For the Vimeo shortcode embed to work as before -- without padding or size issues
What happened instead
The embed area has an excessive height or is small.
Screenshots
The text was updated successfully, but these errors were encountered: