Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo: add new shortcode format #14418

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Vimeo: add new shortcode format #14418

merged 2 commits into from
Jan 22, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 21, 2020

Fixes #14279

Changes proposed in this Pull Request:

We previously only supported 2 main shortcode formats:

  • the old format (w=350&h=500) that relies on shorthand for width and height (w and h), with all shortcode attributes in one string separated by &
  • the new format (width=350 height=500) that relies on the full words

However our implementation unofficially supported a third, mixed format,
with the w and h shorthand supported in the new format.

This commit makes that third format official.

Testing instructions:

  • Do all Unit Tests pass?
  • In a new post, try inserting the following shortcodes:
    [vimeo 368043020 w=640 h=360]
    [vimeo 368043020 w=640&h=360]
    [vimeo 368043020 width=640 height=360]
  • All three should work.

Proposed changelog entry for your changes:

  • Vimeo: add new shortcode format.

Fixes #14279

We previously only supported 2 main shortcode formats:
- the old format (w=350&h=500) that relies on shorthand for width and height (w and h), with all shortcode attributes in one string separated by &
- the new format (width=350 height=500) that relies on the full words

However our implementation unofficially supported a third, mixed format,
with the w and h shorthand supported in the new format.

This commit makes that third format official.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 21, 2020
@jeherve jeherve added this to the 8.2 milestone Jan 21, 2020
@jeherve jeherve requested a review from a team January 21, 2020 14:19
@jeherve jeherve self-assigned this Jan 21, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D37944-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 23, 2020.
Scheduled code freeze: January 16, 2020

Generated by 🚫 dangerJS against b8686d1

Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three examples worked on a fresh site. 🚢

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 21, 2020
@jeherve jeherve merged commit aa3ad69 into master Jan 22, 2020
@jeherve jeherve deleted the add/vimeo-shortcode-format branch January 22, 2020 07:51
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 22, 2020
@jeherve
Copy link
Member Author

jeherve commented Jan 22, 2020

r201918-wpcom

jeherve added a commit that referenced this pull request Jan 27, 2020
jeherve added a commit that referenced this pull request Jan 28, 2020
* [not verified] Remove empty readme section

* Initial changelog for 8.2

* Changelog: add #14220

* Changelog: add #14252

* Changelog: add #14291

* Changelog: add #14309

* Changelog: add #14304

* Changelog: add general connection log.

* Changelog: add #14275

* Changelog: add #14313

* Changelog: add #14213

* Changelog: add #14357

* Add sync testing instructions

* Add 8.1.1 changelog back

See eeaafab and 61757eb

* Changelog: add #14371

* Changelog: add #14386

* Changelog: add #14471

* Changelog: add #14325

* Changelog: add #14194

* Changelog: add #14340

* Changelog: add #14418

* Changelog: add #14417

* Changelog: add #14075

* Changelog: add #14467

* Changelog: add #14307

* Changelog: add #14326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vimeo Shortcode Embed: Broken Formatting after Recent Update
4 participants