-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vimeo: add new shortcode format #14418
Conversation
Fixes #14279 We previously only supported 2 main shortcode formats: - the old format (w=350&h=500) that relies on shorthand for width and height (w and h), with all shortcode attributes in one string separated by & - the new format (width=350 height=500) that relies on the full words However our implementation unofficially supported a third, mixed format, with the w and h shorthand supported in the new format. This commit makes that third format official.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 23, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All three examples worked on a fresh site. 🚢
r201918-wpcom |
* [not verified] Remove empty readme section * Initial changelog for 8.2 * Changelog: add #14220 * Changelog: add #14252 * Changelog: add #14291 * Changelog: add #14309 * Changelog: add #14304 * Changelog: add general connection log. * Changelog: add #14275 * Changelog: add #14313 * Changelog: add #14213 * Changelog: add #14357 * Add sync testing instructions * Add 8.1.1 changelog back See eeaafab and 61757eb * Changelog: add #14371 * Changelog: add #14386 * Changelog: add #14471 * Changelog: add #14325 * Changelog: add #14194 * Changelog: add #14340 * Changelog: add #14418 * Changelog: add #14417 * Changelog: add #14075 * Changelog: add #14467 * Changelog: add #14307 * Changelog: add #14326
Fixes #14279
Changes proposed in this Pull Request:
We previously only supported 2 main shortcode formats:
w=350&h=500
) that relies on shorthand for width and height (w
andh
), with all shortcode attributes in one string separated by&
width=350 height=500
) that relies on the full wordsHowever our implementation unofficially supported a third, mixed format,
with the
w
andh
shorthand supported in the new format.This commit makes that third format official.
Testing instructions:
[vimeo 368043020 w=640 h=360]
[vimeo 368043020 w=640&h=360]
[vimeo 368043020 width=640 height=360]
Proposed changelog entry for your changes: