Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown block: buttons lost visual CSS with Gutenberg 7.7 #14978

Closed
simison opened this issue Mar 13, 2020 · 3 comments · Fixed by #15315
Closed

Markdown block: buttons lost visual CSS with Gutenberg 7.7 #14978

simison opened this issue Mar 13, 2020 · 3 comments · Fixed by #15315
Assignees
@jeherve
Labels
[Feature] Markdown [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.4

Comments

@simison
Copy link
Member

simison commented Mar 13, 2020

Testing with Gutenberg 7.7 on WordPress.com simple sites, I see this:

image

I expected it to look like core HTML block:

image
@simison simison added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Markdown [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Mar 13, 2020
@jeherve
Copy link
Member

jeherve commented Mar 13, 2020

Noting that this may get fixed by #14446.

@jeherve jeherve added this to the 8.4 milestone Mar 13, 2020
@jeherve jeherve mentioned this issue Mar 13, 2020
Closed
14 tasks
@apeatling
Copy link
Member

Let's wait for #14446 to merge and then tackle this if it's still an issue. Moving to blocked until that merges.

@jeherve
Copy link
Member

jeherve commented Mar 27, 2020

It seems it's still an issue, unfortunately.

@jeherve jeherve self-assigned this Apr 6, 2020
jeherve added a commit that referenced this issue Apr 6, 2020
@jeherve
Markdown Block: ensure the editor buttons look good everywhere
3b639b0 
Fixes #14978

This adds additional classes so the button can be properly styled by the editor.
@jeherve jeherve mentioned this issue Apr 6, 2020
Merged
jeherve added a commit that referenced this issue Apr 7, 2020
@jeherve
Markdown Block: ensure the editor buttons look good everywhere (#15315)
fddaecf 
Fixes #14978

This adds additional classes so the button can be properly styled by the editor.
jeherve added a commit that referenced this issue Apr 7, 2020
@jeherve
[not verified] Markdown Block: ensure the editor buttons look good ev…
a579a9f 
…erywhere (#15315)

Fixes #14978

This adds additional classes so the button can be properly styled by the editor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Markdown [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging a pull request may close this issue.

Markdown Block: ensure the editor buttons look good everywhere Automattic/jetpack
3 participants
@simison @jeherve @apeatling