-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Block: ensure the editor buttons look good everywhere #15315
Conversation
Fixes #14978 This adds additional classes so the button can be properly styled by the editor.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 7, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I tested with WP 5.4, WP 5.3.2, and WP 5.4 + Gutenberg. In all three environments, the Markdown block toolbar buttons were properly styled.
Cherry-picked to |
r205468-wpcom |
Fixes #14978
Changes proposed in this Pull Request:
Before
After (WP 5.3.2)
After (WP 5.4)
After (WP 5.4 + Gutenberg / WordPress.com)
Testing instructions:
This is worth trying in different environments: WP 5.3.2, WP 5.4, and WP 5.4 + Gutenberg
Proposed changelog entry for your changes: