Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown Block: ensure the editor buttons look good everywhere #15315

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Markdown Block: ensure the editor buttons look good everywhere #15315

merged 1 commit into from
Apr 7, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 6, 2020 •
edited
Loading

Fixes #14978

Changes proposed in this Pull Request:

  • This adds additional classes so the button can be properly styled by the editor.

Before

image

After (WP 5.3.2)

image

After (WP 5.4)

image

After (WP 5.4 + Gutenberg / WordPress.com)

image

Testing instructions:

This is worth trying in different environments: WP 5.3.2, WP 5.4, and WP 5.4 + Gutenberg

  • Start with a Jetpack site connected to WordPress.com.
  • In the Block editor, add a new Markdown block.
  • Check the block toolbar appearing above the block.

Proposed changelog entry for your changes:

  • N/A

@jeherve
Markdown Block: ensure the editor buttons look good everywhere
3b639b0 
Fixes #14978

This adds additional classes so the button can be properly styled by the editor.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Markdown [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Cherry-Pick labels Apr 6, 2020
@jeherve jeherve added this to the 8.4 milestone Apr 6, 2020
@jeherve jeherve requested a review from a team as a code owner April 6, 2020 18:00
@jeherve jeherve self-assigned this Apr 6, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D41448-code before merging this PR. Thank you!

@jeherve jeherve mentioned this pull request Apr 6, 2020
Closed
14 tasks
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 3b639b0

@jeherve jeherve added the [Status] Needs Design Review Design has been added. Needs a review! label Apr 6, 2020
keoshi
keoshi approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keoshi keoshi removed the [Status] Needs Design Review Design has been added. Needs a review! label Apr 6, 2020
kbrown9
kbrown9 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@kbrown9 kbrown9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I tested with WP 5.4, WP 5.3.2, and WP 5.4 + Gutenberg. In all three environments, the Markdown block toolbar buttons were properly styled.

@kbrown9 kbrown9 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 7, 2020
@jeherve jeherve merged commit fddaecf into master Apr 7, 2020
@jeherve jeherve deleted the fix/markdown-editor-button branch April 7, 2020 06:38
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 7, 2020
jeherve added a commit that referenced this pull request Apr 7, 2020
@jeherve
[not verified] Markdown Block: ensure the editor buttons look good ev…
a579a9f 
…erywhere (#15315)

Fixes #14978

This adds additional classes so the button can be properly styled by the editor.
@jeherve
Copy link
Member Author

jeherve commented Apr 7, 2020

Cherry-picked to branch-8.4 in a579a9f

@jeherve
Copy link
Member Author

jeherve commented Apr 7, 2020

r205468-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keoshi keoshi keoshi approved these changes

@kbrown9 kbrown9 kbrown9 approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Markdown [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Markdown block: buttons lost visual CSS with Gutenberg 7.7
5 participants
@jeherve @matticbot @jetpackbot @keoshi @kbrown9