Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Logo doesn't comply with current branding guidelines #15954

Open
greenweeds opened this issue May 27, 2020 · 11 comments · Fixed by #16294
Open

Facebook Logo doesn't comply with current branding guidelines #15954

greenweeds opened this issue May 27, 2020 · 11 comments · Fixed by #16294
Assignees
Labels
[Block] Social Previews Social Previews Extension [Feature] Comments [Feature] Extra Sidebar Widgets [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Feature] Theme Tools [Pri] Normal [Status] Needs Design [Type] Bug When a feature is broken and / or not performing as intended

Comments

@greenweeds
Copy link

The default icons used for Facebook in social sharing don't comply with current branding guidelines. A screensnip of the out of date icon being served is attached [1], along with the preferred icon [2].

Up to date branding can be accessed at https://en.facebookbrand.com/

[1]
default-facebook-icon-in-jetpack

[2]
f_logo_RGB-Blue_72

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Good For Community [Feature] Sharing Post sharing, sharing buttons [Pri] Low and removed Good For Community labels May 27, 2020
@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended and removed [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels May 28, 2020
@kraftbj kraftbj added this to the 8.7 milestone May 28, 2020
@jeherve
Copy link
Member

jeherve commented May 28, 2020

For reference, the logo comes from here:
https://github.com/Automattic/social-logos

Once it is updated in that repo, we can update our copy of social logos here in Jetpack, and adjust the CSS of the sharing buttons to make an exception for the Facebook icon so it can come until the edge of the circle vs. being in the center like all the others today.

image

We'll also need to update the SVG and the CSS used in the Social Menus and Social Icons widget:
https://github.com/Automattic/jetpack/blob/63fee0f63b8cb1e7909d8b98a50519f9a12eb800/modules/theme-tools/social-menu/social-menu.svg

Internal discussion:
p1590665359354000-slack-jetpack

@keoshi
Copy link
Contributor

keoshi commented May 28, 2020

Thanks for bringing this up, @greenweeds !

Yeah, it seems FB's guidelines have become really restrictive in terms of the logo options they offer (which is now just one).

Ditto on what @jeherve said above on creating an exception for FB, even though the circle should ideally be part of the logo. It should look like this in relation to other logos:

image

This brings up the question of revising all social logos and their latest guidelines and, eventually and more importantly, decide if we still offer multiple options in terms of social icon styling for this block.

@folletto
Copy link
Contributor

I think the quick fix for this is:

Screenshot 2020-05-28 at 13 18 23

Mostly because of what you mentioned it would create and exception for Facebook, and it would also not work with the other styles for social sharing.

@keoshi
Copy link
Contributor

keoshi commented May 28, 2020

Great point, @folletto — that would allow us to stay in line with their guidelines while still offering various styling flavors.

@jeherve
Copy link
Member

jeherve commented Jun 22, 2020

I'm adding the Needs Design label on this one again, as I am not quite sure how to go about updating the Social Logos repo with an updated SVG and icon in the font family, that would reflect the design changes above. @keoshi Do you think you could take a look at this?

Thank you!

@folletto
Copy link
Contributor

I am not quite sure how to go about updating the Social Logos repo with an updated SVG and icon in the font family, that would reflect the design changes above

The logo seems already updated there: Automattic/social-logos#94

You probably just need to pull the latest version?

@jeherve jeherve self-assigned this Jun 26, 2020
jeherve added a commit that referenced this issue Jun 26, 2020
Fixes #15954

This update the icon font and the svg, bringing the changes from this:
Automattic/social-logos#94
@jeherve jeherve removed this from the 8.7 milestone Aug 4, 2020
@jeherve
Copy link
Member

jeherve commented Aug 4, 2020

Reopening as there are still a few places where we'd need to update things:

  • Publicize in wp-admin (and soon Social Previews in wp-admin)

image

  • Publicize in Calypso

image

  • The comment form on WordPress.com and Jetpack

image

@jeherve jeherve reopened this Aug 4, 2020
@jeherve jeherve added [Pri] Normal [Block] Social Previews Social Previews Extension labels Aug 4, 2020
@mdrovdahl
Copy link

Noting a related issue...when using the Jetpack Social Media Icons Widget (https://jetpack.com/support/extra-sidebar-widgets/social-icons-widget/) AND the Jetpack Social Sharing (https://jetpack.com/support/sharing/) set to "icon only" we end up with two different Facebook icons...

ephemeral-mdrovdahl-20200907 atomicsites blog_2020_09_07_hello-world_

@jeherve
Copy link
Member

jeherve commented Sep 7, 2020

@mdrovdahl Are you referring to the fact that the sharing button has the logo inside a circle? If so, that's something we discussed here:
#15954 (comment)

@mdrovdahl
Copy link

@jeherve I think...yes? I read the comments but I'm not clear if the screenshot I provided is indeed the expected behavior. It seems odd that Jetpack places two different Facebook icons on that page (the first a blue circle with a white circle inside with a white f on the inside and the second a red circle with a white f on the inside).

@jeherve
Copy link
Member

jeherve commented Sep 8, 2020

That is indeed the expected behaviour, due to the limitations of the sharing button design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Previews Social Previews Extension [Feature] Comments [Feature] Extra Sidebar Widgets [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Feature] Theme Tools [Pri] Normal [Status] Needs Design [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants