-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Facebook logo, and add .DS_Store to gitignore #94
Conversation
This PR does two things. 1. It updates the Facebook logo to respect new brand guidelines from https://en.facebookbrand.com. 2. It adds .DS_Store files to the .gitignore.
Design wise it's good, but the commit shouldn't update all the PDFs, there should be just one update. I'm not sure what's going on. I've tried to run it from scratch and I get the same update needed on the master branch if I try to do it with no changes, so there's something I think in the PDF package versioning. There was a mention by Dave in #93 — probably locking I'm now not sure if we should merge this, and then lock the version, or if it's better to lock the version in a separate PR that updates all the PDFs too, and then we re-do this PR from there. Thoughts? |
There's no urgency to this pr, so I'll be happy to take a stab at a version tomorrow without the PDFs. Thanks so much for the review! |
Ok sounds good, ping me for review if you try the other PR! :D |
Thank you. I'll also look at the PDFs... Maybe they SHOULD be merged, I suppose running the build process a couple of times and looking if they change can reveal something too. Or maybe I need a fresh npm install! In any case great catch. |
Okay, tried an npm install and npm run build. And all the PDFs changed again, but where before they were smaller, now they're bigger ¯_(ツ)_/¯. However after a push, I ran an additional npm run build, and here's what a diff shows: and another npm run build causes this: So that's at least stable and consistent, and "just an ID" that's changing. I don't know why the ID is changing, I don't know if we can toggle it off in the build tools, but at least it's consistent. I looked at svg-to-pdfkit which is what we're using: https://www.npmjs.com/package/svg-to-pdfkit — there doesn't seem to be a way to keep the ID from changing. So we now have a choice to make:
I'm okay with either! thanks for looking again. |
This is very frustrating, it will make reviews harder for no benefit. I don't want to block the PR to take time to scout how to disable that, so let's go ahead and merge the changes. Let's merge this PR, making clear in the merge notes that this changes both the single PDF as well as the build for all the others. |
I didn't look super deep, I just couldn't find a flag to stop the ID from changing. There might still be. I agree, by the way. Okay, I'll merge this one, and yeah it should affect Gridicons too :| |
Fixes #15954 This update the icon font and the svg, bringing the changes from this: Automattic/social-logos#94
This PR does two things.
The old icon:
The new icon:
Pixels: