Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: Fatal error on PHP 7.2RC coming from WPCOM_JSON_API_Bulk_Delete_Post_Endpoint::callback #8186

Closed
oskosk opened this issue Nov 16, 2017 · 0 comments
Closed

Sync: Fatal error on PHP 7.2RC coming from WPCOM_JSON_API_Bulk_Delete_Post_Endpoint::callback #8186

oskosk opened this issue Nov 16, 2017 · 0 comments
Assignees
@oskosk @roccotripaldi
Labels
[Package] Sync [Type] Bug When a feature is broken and / or not performing as intended
Milestone
5.6

Comments

@oskosk
Copy link
Contributor

oskosk commented Nov 16, 2017

Declaration of WPCOM_JSON_API_Bulk_Delete_Post_Endpoint::callback is not compatible with WPCOM_JSON_API_Update_Post_v1_1_Endpoint::callback.

Steps to reproduce the issue

  • Get to Calypso and try to run a full sync for a site running on PHP 7.2

What I expected

  • No fatal in the site.

What happened instead

  • Logs on the site show this Fatal error 
      Declaration of WPCOM_JSON_API_Bulk_Delete_Post_Endpoint::callback($path = '', $blog_id = 0) must be compatible with WPCOM_JSON_API_Update_Post_v1_1_Endpoint::callback($path = '', $blog_id = 0, $post_id = 0)
  Type: PHP Fatal error Line: 0
  File: json-endpoints/class.wpcom-json-api-bulk-delete-post-endpoint.php
  • Calypso shows this warning
    image
@oskosk oskosk added [Package] Sync [Type] Bug When a feature is broken and / or not performing as intended labels Nov 16, 2017
@oskosk oskosk added this to the 5.6 milestone Nov 16, 2017
@jeherve jeherve mentioned this issue Nov 16, 2017
Closed
13 tasks
@oskosk oskosk mentioned this issue Nov 17, 2017
Merged
@oskosk oskosk self-assigned this Nov 17, 2017
roccotripaldi added a commit that referenced this issue Nov 17, 2017
@roccotripaldi
JSON API: WPCOM_JSON_API_Bulk_Delete_Post_Endpoint
68420bf 
Callback should be called with the same params as the parent's callback.

fixes #8186
@roccotripaldi roccotripaldi mentioned this issue Nov 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskosk oskosk

@roccotripaldi roccotripaldi

Labels
[Package] Sync [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
5.6
Development

Successfully merging a pull request may close this issue.

JSON API: WPCOM_JSON_API_Bulk_Delete_Post_Endpoint Automattic/jetpack
2 participants
@oskosk @roccotripaldi