Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON API: WPCOM_JSON_API_Bulk_Delete_Post_Endpoint #8205

Closed
wants to merge 1 commit into from

Conversation

roccotripaldi
Copy link
Member

Callback should be called with the same params as the parent's callback.

fixes #8186

@oskosk can you verify this fixes the fatal in php 7.2?

Callback should be called with the same params as the parent's callback.

fixes #8186
@roccotripaldi roccotripaldi added [Feature] WPCOM API [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Nov 17, 2017
@roccotripaldi roccotripaldi requested a review from oskosk November 17, 2017 21:31
@roccotripaldi roccotripaldi requested a review from a team as a code owner November 17, 2017 21:31
@oskosk
Copy link
Contributor

oskosk commented Nov 17, 2017

@roccotripaldi unfortunately a full sync also seems to hit other endpoints that have the same problem too. A few mins ago I pushed #8203 similar to yours but covering other endpoints. @enejb is helping review.

@roccotripaldi
Copy link
Member Author

Closing in favor of the more thorough #8203

@matticbot matticbot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 17, 2017
@jeherve jeherve deleted the fix-8186 branch November 20, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WPCOM API Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync: Fatal error on PHP 7.2RC coming from WPCOM_JSON_API_Bulk_Delete_Post_Endpoint::callback
3 participants