-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Page: Disable/hide setting when module is forced on/off #8800
Labels
Admin Page
React-powered dashboard under the Jetpack menu
[Type] Bug
When a feature is broken and / or not performing as intended
Milestone
Comments
ebinnion
added
[Type] Bug
When a feature is broken and / or not performing as intended
Admin Page
React-powered dashboard under the Jetpack menu
labels
Feb 9, 2018
This was referenced Feb 12, 2018
Indeed, I encountered a similar problem when working on Admin Page: Hide Masterbar toggle for Atomic Sites. Ended up filtering by a custom check about Atomic sites, but there could be something better |
matticbot
pushed a commit
that referenced
this issue
Feb 16, 2018
…se format to add override Currently, it is possible to override the active modules in Jetpack and force some to be active or inactive. The issue with this is that our UI does not respond to that. So, while a module may be forced on, a user is shown UI that allows them to attempt to disable the module, except, when the page is refreshed, the module is still enabled. See: #8836 See: #8800 Differential Revision: D10224-code This commit syncs r170223-wpcom.
This was referenced Feb 16, 2018
dereksmart
pushed a commit
that referenced
this issue
Feb 21, 2018
…se format to add override (#8863) Currently, it is possible to override the active modules in Jetpack and force some to be active or inactive. The issue with this is that our UI does not respond to that. So, while a module may be forced on, a user is shown UI that allows them to attempt to disable the module, except, when the page is refreshed, the module is still enabled. See: #8836 See: #8800 Differential Revision: D10224-code This commit syncs r170223-wpcom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Admin Page
React-powered dashboard under the Jetpack menu
[Type] Bug
When a feature is broken and / or not performing as intended
It is currently possible to force a module to be enabled, or disabled, via the jetpack_active_modules filter. Here's an example of using that filter to force the Photon module on:
However, while that filter does force the module on, the UI is not aware that the Photon module is forced on. Because of this, I am able to deactivate Photon in the admin UI. But, when I refresh the page, the module is still active.
We should find some way to manage the UI when modules are forced on. It seems like we should either 1) disable the setting in the UI with a message that it is forced to active or 2) just hide the setting like we do when the module is filtered with the jetpack_get_available_modules filter.
The text was updated successfully, but these errors were encountered: