Admin Page: Add module overrides to react UI

[ebinnion]

Fixes #8800

In Progress

[ebinnion]

I just pushed a commit that takes a first pass at adding module override support to the writing tab. It doesn't yet handle infinite scroll or custom content types as those modules have some unique logic. Here are some screenshots for early review:

Lazy Images and Photon forced on:

Masterbar, minileven, and post by email forced off:

Currently, the toggles are disabled, but there is no explanation of why. I'm currently debating adding an explanation at the end of the module description or adding a popover to the disabled toggle. What do you think?

[oskosk]

Last time I had to disable a piece of ui for settings I was recommended to hide it instead of disabling (It was the case of the masterbar for AT sites where we force the activation of the module via a filter). #8290 (comment)

[ebinnion]

I had considered that approach. I went with this approach so far for two reasons:

1. Devs can completely removed the module using the jetpack_get_available_modules filter.
2. What happens if a user reads about a setting and expects to see it in their Jetpack admin, but we've completely removed it? I think this would make me feel that Jetpack is broken as opposed to my host configuring the module on/off.

Just removing the modules would make my life a lot easier though ;)

[rickybanister]

@oskosk I'd asked @ebinnion and crew to provide two different pathways for module activation—one where we fully hide a piece of UI from the interface (so that that code can't run at all OR to ensure a feature is always on behind the scenes without any user interaction) as well as a visible 'always on' or 'always off' mode. This would be desirable in certain situations where a site builder or agency would like to require their clients use or do not use a certain feature.

@ebinnion in this case (the feature being forced into an on or off position) I think the work you did here is perfect. I was going to suggest we add an inline 'info' style notice to each settings card if they are in the 'always on' or 'off' position explaining what's going on, but that may be a bit overbearing. Another solution would be to swap the (i) icon for a warning icon (!) (make the icon red perhaps instead of gray), and use the popover component to display the reason the controls are disabled. Does that make sense?

Something like this:

It may be useful to switch the info icon to something like the warning icon to make it more apparent that something has changed.

My copy works well I think (outside of thingy thing), but obviously we'll need to properly explain why the feature is on or off.

[oskosk]

@rickybanister that's fine. I just wanted to drop a designer opinion about the first time this was done in the admin page.

that was done after having received feedback from a user of an atomic site that just thought the option was there for him to take the masterbar out of his site because we showed him the toggle. Although after seeing the toggle wasn't doing it and was remaining enabled after page refresh, he just thought it was a bug.

[ebinnion]

At this point, toggles and radios should be disabled when overridden for the writing, sharing, and discussion tabs.

[ebinnion]

Closing in favor of #8934