Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JITMs: add redux structure and REST API client method to be used by the JITM component of the Jetpack Dashboard (Spin-off of #10759). #10818

Merged
merged 6 commits into from
Dec 5, 2018
Merged

JITMs: add redux structure and REST API client method to be used by the JITM component of the Jetpack Dashboard (Spin-off of #10759). #10818

merged 6 commits into from
Dec 5, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Dec 4, 2018 •
edited
Loading

This PR is an extract of #10759 in order to simplify that PR and scope it to UI changes.

Author: @jeherve

Changes proposed in this Pull Request:

  • Introduces _inc/client/state/jitm and files for reducer, actions and tests.
  • Introduces method fetchJitm in the REST API client.

Testing instructions:

  • Checkout this branch
  • Run yarn test-client _inc/client/state/jitm/test/*
  • Confirm tests pass

Proposed changelog entry for your changes:

None needed

@oskosk oskosk added [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Dec 4, 2018
@oskosk oskosk requested a review from a team as a code owner December 4, 2018 20:42
@oskosk oskosk requested a review from jeherve December 4, 2018 20:42
@oskosk oskosk changed the title JITMs: add redux structure and rest api client method to be used the JITM component of the Jetpack Dashboard. JITMs: add redux structure and REST API client method to be used the JITM component of the Jetpack Dashboard (Spin-off of #10759). Dec 4, 2018
@oskosk oskosk changed the title JITMs: add redux structure and REST API client method to be used the JITM component of the Jetpack Dashboard (Spin-off of #10759). JITMs: add redux structure and REST API client method to be used bt the JITM component of the Jetpack Dashboard (Spin-off of #10759). Dec 4, 2018
@oskosk oskosk changed the title JITMs: add redux structure and REST API client method to be used bt the JITM component of the Jetpack Dashboard (Spin-off of #10759). JITMs: add redux structure and REST API client method to be used by the JITM component of the Jetpack Dashboard (Spin-off of #10759). Dec 4, 2018
@oskosk oskosk force-pushed the add/jitm-adminpage-redux-structure branch from e273a5a to 870d27c Compare December 4, 2018 21:26
@jetpackbot
Copy link

jetpackbot commented Dec 4, 2018 •
edited
Loading

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@brbrr
Copy link
Contributor

brbrr commented Dec 5, 2018

I've pushed a test fix. Hope you don't mind :)

brbrr
brbrr previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 5, 2018
@oskosk
Copy link
Contributor Author

oskosk commented Dec 5, 2018

thanks!

@jeherve jeherve force-pushed the add/jitm-adminpage-redux-structure branch from e6a00c7 to d99720c Compare December 5, 2018 13:48
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 5, 2018
jeherve
jeherve approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, this should be good to merge. Thanks for all the help!

@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 5, 2018
@jeherve jeherve merged commit dabff02 into master Dec 5, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 5, 2018
@jeherve jeherve deleted the add/jitm-adminpage-redux-structure branch December 5, 2018 13:55
@jeherve jeherve mentioned this pull request Dec 5, 2018
Closed
4 tasks
jeherve added a commit that referenced this pull request Dec 7, 2018
@jeherve
Revert "JITMs: add redux structure and REST API client method to be u…
4ece278 
…sed by the JITM component of the Jetpack Dashboard (Spin-off of #10759). (#10818)"

This reverts commit dabff02.
We will take a different approach, outlined in #10889
@jeherve jeherve mentioned this pull request Dec 7, 2018
Merged
jeherve added a commit that referenced this pull request Dec 7, 2018
@jeherve
JITMs: revert redux changes for new JITM component (#10890)
0a3d37f 
#### Changes proposed in this Pull Request:
Revert "JITMs: add redux structure and REST API client method to be u…sed by the JITM component of the Jetpack Dashboard (Spin-off of #10759). (#10818)"

This reverts commit dabff02.
We will take a different approach, outlined in #10889

#### Testing instructions:

* None

#### Proposed changelog entry for your changes:

* None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@brbrr brbrr brbrr left review comments

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oskosk @jetpackbot @brbrr @jeherve @matticbot