-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITMs: add redux structure and REST API client method to be used by the JITM component of the Jetpack Dashboard (Spin-off of #10759). #10818
Conversation
e273a5a
to
870d27c
Compare
This is automated check which relies on Generated by 🚫 dangerJS |
I've pushed a test fix. Hope you don't mind :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚢
thanks! |
e6a00c7
to
d99720c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, this should be good to merge. Thanks for all the help!
#### Changes proposed in this Pull Request: Revert "JITMs: add redux structure and REST API client method to be u…sed by the JITM component of the Jetpack Dashboard (Spin-off of #10759). (#10818)" This reverts commit dabff02. We will take a different approach, outlined in #10889 #### Testing instructions: * None #### Proposed changelog entry for your changes: * None
This PR is an extract of #10759 in order to simplify that PR and scope it to UI changes.
Author: @jeherve
Changes proposed in this Pull Request:
_inc/client/state/jitm
and files for reducer, actions and tests.fetchJitm
in the REST API client.Testing instructions:
yarn test-client _inc/client/state/jitm/test/*
Proposed changelog entry for your changes:
None needed