-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITMs: display more relevant notices depending on the Jetpack dashboard screen you visit. #10889
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. |
#### Changes proposed in this Pull Request: Revert "JITMs: add redux structure and REST API client method to be u…sed by the JITM component of the Jetpack Dashboard (Spin-off of #10759). (#10818)" This reverts commit dabff02. We will take a different approach, outlined in #10889 #### Testing instructions: * None #### Proposed changelog entry for your changes: * None
c99ca033e20d73c730dee78377b064db375989b8 was applied to fix an issue when there was not jitm card before changing routes
|
When navigating among settings tabs apparently we're querying for JITMs twice |
ab92b7a
to
c99ca03
Compare
c99ca03
to
c0335a2
Compare
That seems to be because we first load URLs like I pushed a quick fix for that in 3fdcfc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works. fine there's a bit of an issue when rapidly switching settings tabs. The previous JITM for the previous JITM will load on the new tab. We'll tackle this on another PR
The issue mentioned about switching tabs rapidly will be tracked in #11028 |
Changes proposed in this Pull Request:
Display more relevant notices depending on the Jetpack dashboard screen you visit.
Testing instructions:
JETPACK__SANDBOX_DOMAIN
constant (reference).sandboxme.wordpress.com
as the sandbox you want to use.Proposed changelog entry for your changes: