Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: new Performance tab. #10941

Merged
merged 4 commits into from
Dec 18, 2018
Merged

Admin Page: new Performance tab. #10941

merged 4 commits into from
Dec 18, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 11, 2018 •
edited
Loading

Fixes #10550

Changes proposed in this Pull Request:

This PR moves existing cards over to a new "Performance" section in Jetpack settings, and makes that "Performance" tab the new default tab you see when heading to Jetpack > Settings in your dashboard.

image

Testing instructions:

  • Go to Jetpack > Settings
  • Make sure all settings work, including the new Performance section.

Proposed changelog entry for your changes:

  • Jetpack Dashboard: add a new "Performance" section

@jeherve jeherve added [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu DO NOT MERGE don't merge it! labels Dec 11, 2018
@jeherve jeherve self-assigned this Dec 11, 2018
@jeherve jeherve requested a review from a team as a code owner December 11, 2018 16:31
@keoshi
Copy link
Contributor

keoshi commented Dec 11, 2018

This PR should be coordinated with #10940 — I'll make sure to at least have the copy ready to go for this new tab.

@jetpackbot
Copy link

jetpackbot commented Dec 11, 2018 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 736819d

@keoshi
Copy link
Contributor

keoshi commented Dec 13, 2018

Added the performance settings description in a6ae3d6

See: #10940

@keoshi
Copy link
Contributor

keoshi commented Dec 14, 2018

Resolved the conflicts above.

jeherve and others added 2 commits December 18, 2018 10:23
@jeherve
Admin Page: new Performance tab.
504f2cb 
- See #10550
- Move existing cards over to a new "Performance" section.
@keoshi @jeherve
Add settings description
1ef419a 
See: #10940
@jeherve jeherve added this to the 6.9 milestone Dec 18, 2018
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! and removed DO NOT MERGE don't merge it! [Status] In Progress labels Dec 18, 2018
@jeherve jeherve requested a review from a team December 18, 2018 12:23
@jeherve jeherve mentioned this pull request Dec 18, 2018
Closed
zinigor
zinigor approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the code, tested in the admin both with usual tabs and in search mode, seems to be working fine!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 18, 2018
jeffgolenski
jeffgolenski approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@jeffgolenski jeffgolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant. Thank you @jeherve @keoshi

@jeffgolenski
Copy link
Member

This is great. Now we just need to push the same changes on the calypso side as well!

@jeffgolenski jeffgolenski mentioned this pull request Dec 18, 2018
Closed
@jeherve jeherve merged commit 98e6370 into master Dec 18, 2018
@ghost ghost removed [Status] Needs Changelog [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 18, 2018
@jeherve jeherve deleted the add/new-performance-tab branch December 18, 2018 14:14
@jeherve jeherve added [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Dec 18, 2018
@keoshi keoshi mentioned this pull request Dec 19, 2018
Merged
@keoshi keoshi mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffgolenski jeffgolenski jeffgolenski approved these changes

@zinigor zinigor zinigor approved these changes

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.
6 participants
@jeherve @keoshi @jetpackbot @jeffgolenski @zinigor @matticbot