JITM: make sure no JITMs can ever be displayed at the same time. #11087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
[Type] Bug
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. |
oskosk
approved these changes
Jan 7, 2019
oskosk
added
[Status] Ready to Merge
|
Seems to me that If the new tab does not have a JITM to show, then the previous message will stay rendered, as reported in #11028. Though, this is outside of the scope of this PR. |
ghost
removed
the
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Jan 8, 2019
) Fixes #11045 #### Changes proposed in this Pull Request: Before to insert a JITM into the admin notices, we now check if one exists first. If we have one, we replace it. #### Testing instructions: * Start from a site that was never connected to WordPress.com before (JN is a great tool for that) * Connect to WordPress.com * Make sure that when you are sent back to the Jetpack dashboard, only one JITM gets displayed. * Navigate to the Plans tab; another JITM should appear. * Navigate to the main dashboard. You should see a message there as well. * There should never be 2 messages. #### Proposed changelog entry for your changes: * None.
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11045
Changes proposed in this Pull Request:
Before to insert a JITM into the admin notices, we now check if one exists first. If we have one, we replace it.
Testing instructions:
Proposed changelog entry for your changes: