-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITM: make sure no JITMs can ever be displayed at the same time. #11087
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Note that if rapidly switching tabs, the previous JITM would show for a short time while the new one is loading but it's ok to me.
Seems to me that If the new tab does not have a JITM to show, then the previous message will stay rendered, as reported in #11028. Though, this is outside of the scope of this PR. |
) Fixes #11045 #### Changes proposed in this Pull Request: Before to insert a JITM into the admin notices, we now check if one exists first. If we have one, we replace it. #### Testing instructions: * Start from a site that was never connected to WordPress.com before (JN is a great tool for that) * Connect to WordPress.com * Make sure that when you are sent back to the Jetpack dashboard, only one JITM gets displayed. * Navigate to the Plans tab; another JITM should appear. * Navigate to the main dashboard. You should see a message there as well. * There should never be 2 messages. #### Proposed changelog entry for your changes: * None.
Cherry-picked to |
Fixes #11045
Changes proposed in this Pull Request:
Before to insert a JITM into the admin notices, we now check if one exists first. If we have one, we replace it.
Testing instructions:
Proposed changelog entry for your changes: