Maps Block: Fix typos in copy of API endpoint #11161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
D23316-code. (newly created revision) |
akirk
commented
Jan 18, 2019
| @@ -78,15 +78,15 @@ public function get_public_item_schema() { | |||
| 'type' => 'object', | |||
| 'properties' => array( | |||
| 'code' => array( | |||
| 'description' => __( 'Displays success if the oppration was successfully executed and an error code if it was not', 'jetpack' ), | |||
| 'description' => __( 'Displays success if the operation was successfully executed and an error code if it was not', 'jetpack' ), | |||
There was a problem hiding this comment.
@enejb Should success be in quotes since this will be the actual text of code?
This is automated check which relies on |
jeherve
added
[Block] Map
[Status] Needs Review
|
Thanks for the pull request! It looks good to me! |
enejb
approved these changes
Jan 18, 2019
|
@Automattic/jetpack-crew it looks like the code was already submitted to .com |
jeherve
removed
the
[Status] Needs Review
jeherve
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our translators have discovered some typos in the descriptions introduced in #10742.
props @iqatrophie