Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps Block: Fix typos in copy of API endpoint #11161

Merged
merged 1 commit into from
Jan 23, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions _inc/lib/core-api/wpcom-endpoints/service-api-keys.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*
* [
* { # Availabilty Object. See schema for more detail.
* code: (string) Displays success if the oppration was successfully executed and an error code if it was not
* code: (string) Displays success if the operation was successfully executed and an error code if it was not
* service: (string) The name of the service in question
* service_api_key: (string) The API key used by the service empty if one is not set yet
* message: (string) User friendly message
Expand Down Expand Up @@ -78,15 +78,15 @@ public function get_public_item_schema() {
'type' => 'object',
'properties' => array(
'code' => array(
'description' => __( 'Displays success if the oppration was successfully executed and an error code if it was not', 'jetpack' ),
'description' => __( 'Displays success if the operation was successfully executed and an error code if it was not', 'jetpack' ),
Copy link
Member Author

@akirk akirk Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enejb Should success be in quotes since this will be the actual text of code?

'type' => 'string',
),
'service' => array(
'description' => __( 'The name of the service in question', 'jetpack' ),
'type' => 'string',
),
'service_api_key' => array(
'description' => __( 'The API key used by the service empty if one is not set yet', 'jetpack' ),
'description' => __( 'The API key used by the service. Empty if none has been set yet', 'jetpack' ),
'type' => 'string',
),
'message' => array(
Expand Down Expand Up @@ -278,4 +278,4 @@ private static function key_for_api_service( $service ) {
}
}

wpcom_rest_api_v2_load_plugin( 'WPCOM_REST_API_V2_Endpoint_Service_API_Keys' );
wpcom_rest_api_v2_load_plugin( 'WPCOM_REST_API_V2_Endpoint_Service_API_Keys' );