-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: allow multi-line submit buttons #11223
Conversation
multi-line submit buttons on the front end.
D23643-code. (newly created revision) |
modules/subscriptions/views.php
Outdated
<?php if ( ! empty( $submit_button_classes ) ) { ?> | ||
class="<?php echo esc_attr( $submit_button_classes ); ?>" | ||
<?php }; ?> | ||
<?php if ( ! empty( $submit_button_styles ) ) { ?> | ||
style="<?php echo esc_attr( $submit_button_styles ); ?>" | ||
<?php }; ?> | ||
name="jetpack_subscriptions_widget" | ||
/> | ||
> | ||
<?php echo wp_kses( $subscribe_button, array( 'br' => array() ) ); ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use $allowed_html_tags_for_submit_button
?
modules/subscriptions/views.php
Outdated
<?php if ( ! empty( $submit_button_classes ) ) { ?> | ||
class="<?php echo esc_attr( $submit_button_classes ); ?>" | ||
<?php }; ?> | ||
<?php if ( ! empty( $submit_button_styles ) ) { ?> | ||
style="<?php echo esc_attr( $submit_button_styles ); ?>" | ||
<?php }; ?> | ||
/> | ||
> | ||
<?php echo wp_kses( $subscribe_button, array( 'br' => array() ) ); ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as here $allowed_html_tags_for_submit_button?
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: February 5, 2019. |
@roccotripaldi We have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me. Merge when ready.
The Contact Form and Subscription form use a submit button component that allows for multiple lines. However, on the front-end, we use an
<input>
tag which does not support new lines within itsvalue
attribute.This PR fixes this issue by using a
<button>
component insteadFixes n/a
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: