Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memberships: fix button presentation #12416

Merged
merged 3 commits into from
May 22, 2019
Merged

Memberships: fix button presentation #12416

merged 3 commits into from
May 22, 2019

Conversation

artpi
Copy link
Contributor

@artpi artpi commented May 20, 2019

During Membership beta, @dbspringer has discovered, that membership button does not render line breaks and @mtias has stumbled upon the horrible fact, that on some themes button is not styled and displays with no panache whatsoever.

To fix this I:

  • Replaced esc_html with wp_kses to not cut out <br/> and few other tags.
  • Attached wp-block-button__link class which is shipped with Gutenberg by default

Screenshot

Zrzut ekranu 2019-05-20 o 17 01 04

Testing instruction

  • Use testing instructions from Membership Block #9802
  • Do a line break and publish - see if there is line break on frontend

@artpi artpi requested a review from a team as a code owner May 20, 2019 15:34
@artpi artpi self-assigned this May 20, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello artpi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28438-code before merging this PR. Thank you!

@artpi artpi added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 20, 2019
@jetpackbot
Copy link

jetpackbot commented May 20, 2019 •
edited
Loading

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 3ac5b7f

@jeherve jeherve added [Block] Payment Button aka Recurring Payments [Type] Bug When a feature is broken and / or not performing as intended labels May 20, 2019
jeherve
jeherve requested changes May 20, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior art with the Mailchimp block in #11403, and the Contact form and Subscription blocks in #11223. I only had one question.

modules/memberships/class-jetpack-memberships.php Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 20, 2019
@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D28438-code has been updated.

@artpi artpi added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels May 21, 2019
@artpi artpi requested a review from jeherve May 21, 2019 04:24
jeherve
jeherve previously approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 21, 2019
@jeherve jeherve added this to the 7.4 milestone May 21, 2019
@artpi artpi force-pushed the memberships/fix-button-presentation branch from a11df4f to 96dfaf4 Compare May 22, 2019 14:27
@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D28438-code has been updated.

@artpi artpi force-pushed the memberships/fix-button-presentation branch from 96dfaf4 to 3ac5b7f Compare May 22, 2019 14:48
@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D28438-code has been updated.

@artpi artpi merged commit 6698e67 into master May 22, 2019
@artpi artpi deleted the memberships/fix-button-presentation branch May 22, 2019 14:59
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 22, 2019
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog & Testing list: add #12416, #12417, #12418, and #12348
118adef
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@mtias mtias Awaiting requested review from mtias

@davemart-in davemart-in Awaiting requested review from davemart-in

@eoigal eoigal Awaiting requested review from eoigal

@prettyboymp prettyboymp Awaiting requested review from prettyboymp

Assignees

@artpi artpi

Labels
[Block] Payment Button aka Recurring Payments Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
5 participants
@artpi @matticbot @jetpackbot @jeherve @mtias