Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medium: update embed method to reflect Medium changes #12170

Merged
merged 8 commits into from
May 8, 2019
Merged

Medium: update embed method to reflect Medium changes #12170

merged 8 commits into from
May 8, 2019

Commits on Apr 26, 2019

  1. Medium: fix all phpcs warnings 

    Also change the display of the HTML markup added alongside the embed script. Instead of displaying a text in English all the time, let's make that text translatable. Since part of the English string came from the embed type before, I simplified the string.
    @jeherve
    jeherve committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    f329a82 View commit details
    Browse the repository at this point in the history

  2. Medium: update list of examples at the top of the file.

    @jeherve
    jeherve committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    aae128c View commit details
    Browse the repository at this point in the history

  3. Display error message when a URL was not given in Medium shortcode

    @jeherve
    jeherve committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    8590db3 View commit details
    Browse the repository at this point in the history

  4. Add unit tests matching the different Medium URL formats avaialble

    @jeherve
    jeherve committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    87a380a View commit details
    Browse the repository at this point in the history

  5. Medium Collections: update regex as URL format has changed. 

    Medium collections now use the following format:
https://medium.com/s/user-friendly

You can find some more examples here:
https://medium.com/collections

We should consequently update how we determine embed type accordingly.
    @jeherve
    jeherve committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    0084d27 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. Tests: display link instead of embed for Medium collections 

    Medium does not support Collection embeds anymore.
    @jeherve
    jeherve committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    e47e387 View commit details
    Browse the repository at this point in the history

  2. Update version numbers

    @jeherve
    jeherve committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    701a9ce View commit details
    Browse the repository at this point in the history

  3. Medium collections: return link instead of trying to embed 

    Medium does not support embedding Medium Collections anymore
    @jeherve
    jeherve committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    4a76587 View commit details
    Browse the repository at this point in the history