-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medium: update embed method to reflect Medium changes #12170
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 7, 2019. |
Also change the display of the HTML markup added alongside the embed script. Instead of displaying a text in English all the time, let's make that text translatable. Since part of the English string came from the embed type before, I simplified the string.
Medium collections now use the following format: https://medium.com/s/user-friendly You can find some more examples here: https://medium.com/collections We should consequently update how we determine embed type accordingly.
2efa2b3
to
0084d27
Compare
I contacted Medium about it directly to try to find out more. Here is an example of the problem: |
Medium does not support Collection embeds anymore.
Medium does not support embedding Medium Collections anymore
They confirmed that the embeds are not supported anymore. The profile and story embeds still work, but they are not maintained. The Collection embeds do not work anymore, and there are no plans to get it fixed. As a result, I updated our shortcode to return a link instead of an embed in those cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice set of finds. Frustrating about the changes on their end, but only so much we can do about that.
Tests nicely.
Even though this started as a PHPCS update, there's enough additional on it that I'm not going to include it as part of the general PHPCS changelog item. |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Changes proposed in this Pull Request:
I originally only wanted to make a few PHPCS fixes. In the process, I discovered some issues:
Matching WordPress.com diff: D27479-code
Testing instructions:
https://medium.com/@jeherve
https://medium.com/s/user-friendly
https://medium.com/@jeherve/this-is-a-story-19f582daaf5b
[medium url="https://medium.com/@jeherve/this-is-a-story-19f582daaf5b" width="100%" border="false" collapsed="true"]
Limitations
In my tests, I can't seem to be able to embed collections, but I am not sure why.
https://api.medium.com/_/embed/s/user-friendly
does not seem correct.Update: I contacted Medium support about this, and they confirmed that the embeds are not supported anymore. The profile and story embeds still work, but they are not maintained. The Collection embeds do not work anymore, and there are no plans to get it fixed. As a result, I updated our shortcode to return a link instead of an embed in those cases.
Proposed changelog entry for your changes: