Analytics: Add tracks to checklist CTAs #12449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Status] Needs Review
This is an automated check which relies on |
jeherve
approved these changes
May 23, 2019
| ? { | ||
| plan: this.props.plan, | ||
| } | ||
| : undefined |
There was a problem hiding this comment.
Don't we always return a plan, even for free users?
There was a problem hiding this comment.
We should, in theory. However, I don't trust that the plan prop will always be correctly provided.
jeherve
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tracking to the Checklist CTAs
jetpack_myplan_headerchecklistcta_clickStatic CTA enabled in the My Plan header at/wp-admin/admin.php?page=jetpack#/my-plan:jetpack_myplan_progresschecklistcta_clickCTA in checklist progress (Not yet in use My plan: Add checklist progress banner #12277).Tracks data includes
planproperty with plan slug.Via #12429 (comment)
Testing instructions
/wp-admin/admin.php?page=jetpack#/my-plan, open network panel and select "preserve log"