-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics: Add tracks to checklist CTAs #12449
Conversation
This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my tests. I only have one remark.
? { | ||
plan: this.props.plan, | ||
} | ||
: undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we always return a plan, even for free users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should, in theory. However, I don't trust that the plan prop will always be correctly provided.
Add tracking to the Checklist CTAs
jetpack_myplan_headerchecklistcta_click
Static CTA enabled in the My Plan header at/wp-admin/admin.php?page=jetpack#/my-plan
:jetpack_myplan_progresschecklistcta_click
CTA in checklist progress (Not yet in use My plan: Add checklist progress banner #12277).Tracks data includes
plan
property with plan slug.Via #12429 (comment)
Testing instructions
/wp-admin/admin.php?page=jetpack#/my-plan
, open network panel and select "preserve log"