Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My plan: Add checklist progress banner #12277

Merged
merged 21 commits into from
May 20, 2019
Merged

My plan: Add checklist progress banner #12277

merged 21 commits into from
May 20, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented May 6, 2019 •
edited
Loading

Prepare checklist UI for the My Plan page:

The checklist is not visible, #12404 will make the checklist functional

Screen Shot 2019-05-08 at 12 39 11

The data layer is in place, but no API calls are made. Endpoints in Jetpack and WordPress.com need to be prepared. Watch #12404 for work there.

Part of Automattic/wp-calypso#32565

Testing

  • Builds 👍
  • No changes at /wp-admin/admin.php?page=jetpack#/my-plan 👍
  • Does the link to Calypso work and direct you to the My Plan page in Calypso?

@sirreal sirreal added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu Plans labels May 6, 2019
@sirreal sirreal self-assigned this May 6, 2019
@sirreal sirreal force-pushed the add/my-plan-checklist-progress branch 2 times, most recently from 099e69e to d82c23d Compare May 7, 2019 14:54
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello sirreal! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27964-code before merging this PR. Thank you!

@sirreal sirreal force-pushed the add/my-plan-checklist-progress branch from f527388 to 97cd181 Compare May 8, 2019 10:35
@sirreal sirreal added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels May 8, 2019
@sirreal sirreal marked this pull request as ready for review May 8, 2019 10:36
@sirreal sirreal requested a review from a team as a code owner May 8, 2019 10:36
@jetpackbot
Copy link

jetpackbot commented May 8, 2019 •
edited
Loading

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 6a8779b

@sirreal sirreal requested a review from a team May 8, 2019 10:39
simison
simison reviewed May 8, 2019
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
simison
simison reviewed May 8, 2019
View reviewed changes
webpack.config.js Outdated Show resolved Hide resolved
@sirreal sirreal force-pushed the add/my-plan-checklist-progress branch from cec2ae2 to 21108a1 Compare May 8, 2019 16:40
@sirreal
Copy link
Member Author

sirreal commented May 8, 2019

Rebased to fix conflict

@matticbot
Copy link
Contributor

sirreal, Your synced wpcom patch D27964-code has been updated.

@sirreal sirreal mentioned this pull request May 8, 2019
Merged
@sirreal sirreal requested review from jeffgolenski and a team May 9, 2019 07:03
@sirreal sirreal force-pushed the add/my-plan-checklist-progress branch from b6e11cd to 6a8779b Compare May 20, 2019 11:14
jeherve
jeherve approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 20, 2019
@sirreal sirreal merged commit b9728ae into master May 20, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 20, 2019
@sirreal sirreal deleted the add/my-plan-checklist-progress branch May 20, 2019 11:56
@sirreal
Copy link
Member Author

sirreal commented May 20, 2019

r191989-wpcom

@jeherve jeherve added this to the 7.4 milestone May 20, 2019
@sirreal sirreal mentioned this pull request May 23, 2019
Merged
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12277
74755c0
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
@sirreal
Copy link
Member Author

sirreal commented Feb 4, 2020

I've closed #12404 with no plans to continue.

It's possible that several files added here are completely unused and can be safely removed. It should be relatively straightforward cleanup.

FYI: @Automattic/jetpack-crew

@jeherve jeherve mentioned this pull request Feb 10, 2020
Open
@jeherve
Copy link
Member

jeherve commented Feb 10, 2020

It's possible that several files added here are completely unused and can be safely removed. It should be relatively straightforward cleanup.

Logged in #14620.

@jeffgolenski
Copy link
Member

Thanks for keeping an eye on this y'all.

Just cc'ing the design team so they know it exists. We may revisit in the future: @keoshi @crunnells @eeeeevon13 @folletto

jeherve added a commit that referenced this pull request Feb 16, 2021
@jeherve
Recommendations: update button in My Plan to go to Recommendations
d529792 
In #12277 and #12429, we added a "checklist" component to the Jetpack dashboard, as well as a CTA that would lead you to the checklist in Calypso.
We never really expanded on that checklist and its display in the React dashboard, but we now have a Recommendations component we use in Jetpack, since #18437.

This commit removes the elements from the checklist that we never used, and updates the CTA link in "My Plan" to point to the new Recommendations, when those recommendations must be shown to site owners.
@jeherve jeherve mentioned this pull request Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ockham ockham ockham left review comments

@jeherve jeherve jeherve approved these changes

@simison simison simison left review comments

@jeffgolenski jeffgolenski jeffgolenski left review comments

Assignees

@sirreal sirreal

Labels
Admin Page React-powered dashboard under the Jetpack menu Plans [Status] Design Review Complete Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
7 participants
@sirreal @matticbot @jetpackbot @jeffgolenski @jeherve @simison @ockham