-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My plan: Add checklist progress banner #12277
Conversation
099e69e
to
d82c23d
Compare
Caution: This PR has changes that must be merged to WordPress.com |
f527388
to
97cd181
Compare
This is an automated check which relies on |
_inc/client/my-plan/checklist-progress-card/progress-bar/screen-reader-text/style.scss
Outdated
Show resolved
Hide resolved
_inc/client/my-plan/checklist-progress-card/progress-bar/style.scss
Outdated
Show resolved
Hide resolved
cec2ae2
to
21108a1
Compare
Rebased to fix conflict |
sirreal, Your synced wpcom patch D27964-code has been updated. |
checklist progress card: adjusting mobile styles for smaller screens
Checklist API requires WPCOM-side work. Disable and remove the data fetching for now.
b6e11cd
to
6a8779b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. 👍
r191989-wpcom |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
I've closed #12404 with no plans to continue. It's possible that several files added here are completely unused and can be safely removed. It should be relatively straightforward cleanup. FYI: @Automattic/jetpack-crew |
Logged in #14620. |
Thanks for keeping an eye on this y'all. Just cc'ing the design team so they know it exists. We may revisit in the future: @keoshi @crunnells @eeeeevon13 @folletto |
In #12277 and #12429, we added a "checklist" component to the Jetpack dashboard, as well as a CTA that would lead you to the checklist in Calypso. We never really expanded on that checklist and its display in the React dashboard, but we now have a Recommendations component we use in Jetpack, since #18437. This commit removes the elements from the checklist that we never used, and updates the CTA link in "My Plan" to point to the new Recommendations, when those recommendations must be shown to site owners.
Prepare checklist UI for the My Plan page:
The checklist is not visible, #12404 will make the checklist functional
The data layer is in place, but no API calls are made. Endpoints in Jetpack and WordPress.com need to be prepared. Watch #12404 for work there.
Part of Automattic/wp-calypso#32565
Testing
/wp-admin/admin.php?page=jetpack#/my-plan
👍Does the link to Calypso work and direct you to the My Plan page in Calypso?