Masterbar: style Recovery mode button #12485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button was added in #12467. This commit styles it so: - It looks similar to the core Recovery mode button when seeing the default Masterbar. - It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
jeherve
added
[Type] Enhancement
scottsweb
added
[Status] Design Review Complete
and removed
[Status] Needs Design Review
|
This looks great to me 👍 |
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
scottsweb
approved these changes
May 31, 2019
dereksmart
approved these changes
Jun 19, 2019
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
jeherve
added a commit
that referenced
this pull request
Jun 27, 2019
The button was added in #12467. This commit styles it so: - It looks similar to the core Recovery mode button when seeing the default Masterbar. - It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The button was added in #12467.
This commit styles it so:
See discussion here to learn more about this:
#12467 (comment)
Before
After with the default Masterbar
After with Calypsoify on
Testing instructions:
wp-includes/load.php, locate thewp_is_recovery_modefunction. Set it to returntrue.http://yoursite/wp-admin/plugins.php?calypsoify=1http://yoursite/wp-admin/Proposed changelog entry for your changes: