-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masterbar: Add recovery mode menu item. #12467
Conversation
Allow users with the masterbar module active to exit recovery mode without needing to log out of their site.
This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me. Not blocking, but I think that maybe we could add some styling to this button in the future, just like for the original menu item?
Something like
diff --git a/modules/masterbar/overrides.css b/modules/masterbar/overrides.css
index aadbe9abf..d6a09be0d 100644
--- a/modules/masterbar/overrides.css
+++ b/modules/masterbar/overrides.css
@@ -75,6 +75,12 @@
font-size: 28px;
}
+.jetpack-masterbar #wpadminbar #wp-admin-bar-recovery-mode {
+ background-color: #ca4a1f;
+ color: #fff;
+ margin-right: 1em;
+}
+
@media screen and (max-width: 480px) {
.jetpack-masterbar.post-new-php.block-editor-page #wp-toolbar ul li {
flex: 1;
@@ -119,4 +125,8 @@
.jetpack-masterbar.post-new-php.block-editor-page #wpadminbar li#wp-admin-bar-newdash {
order: 3;
}
+
+ .jetpack-masterbar #wpadminbar #wp-admin-bar-recovery-mode {
+ display: none;
+ }
}
What do you think?
Merging this one for now. Styling can come in a future PR if needed. |
Don’t have enough context here, but have you tried just color the font? It would conflict less with everything else.
Thanks,
Pablo
… On May 27, 2019, at 11:02 AM, Jeremy Herve ***@***.***> wrote:
@Automattic/jetpack-design What's your take on the above?
vs.
Noting that I used WordPress' color here, #ca4a1f. I'm not sure what Muriel's color would be here. $muriel-hot-yellow-400?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
To give you more context, this is an element that usually appears in the admin bar on self-hosted WordPress sites. We want to implement the same button in the WordPress.com admin bar, on Jetpack sites (self-hosted, but mostly Atomic). The button will only appear when something is wrong on your site, and you need to take action. |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Because this button originally comes from core, I think we can stick with core colours in this instance. If a user has the calypsoified theme enabled on wp-admin though, then I think using the orange would make more sense - that indicates to me they are probably an Atomic user. |
The button was added in #12467. This commit styles it so: - It looks similar to the core Recovery mode button when seeing the default Masterbar. - It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
The user don’t know what Atomic and other nuances are : )
I understand the user won’t be interacting in both environments, right?
For the sake of respecting the clean .com bar, I’d color the text in red/orange (the usual color for errors?) rather than a box/background.
Cheers,
_
Pablo Honey
Sr. Design Director, ProdX
pablo@automattic.com
Brooklyn, NYC (US)
EST
… On May 28, 2019, at 3:25 AM, Scott Evans ***@***.***> wrote:
Because this button originally comes from core, I think we can stick with core colours in this instance.
If a user has the calypsoified theme enabled on wp-admin though, then I think using the orange would make more sense - that indicates to me they are probably an Atomic user.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub <#12467?email_source=notifications&email_token=AGCVUQ7EJ753GCCDJNTBSQDPXUCCBA5CNFSM4HPTHCYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWLVV6Y#issuecomment-496458491>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGCVUQ2UKSRUMXRVJN7UCN3PXUCCBANCNFSM4HPTHCYA>.
|
Not on Atomic, no, but on Jetpack one can freely activate and deactivate the WordPress.com toolbar feature, thus going from the core admin bar to the WordPress.com toolbar as they please.
Like so? If so, it seems we would have to make that text bold as well: https://webaim.org/resources/contrastchecker/?fcolor=CA4A1F&bcolor=23282D Would that work? |
The button was added in #12467. This commit styles it so: - It looks similar to the core Recovery mode button when seeing the default Masterbar. - It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
The button was added in #12467. This commit styles it so: - It looks similar to the core Recovery mode button when seeing the default Masterbar. - It uses the Calypso colors when the Masterbar is loaded by a user using Calypsoify
Allow users with the masterbar module active to exit recovery mode without needing to log out of their site.
Testing instructions:
Proposed changelog entry for your changes: