Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering on categories and tags #13505

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

jsnmoon
Copy link
Member

@jsnmoon jsnmoon commented Sep 20, 2019

Changes proposed in this Pull Request:

This enables filtering search results via search widget checkboxes.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Yes, this adds categories and tags filtering to Jetpack Instant Search.

Testing instructions:

  • Add define( "JETPACK_SEARCH_PROTOTYPE", true ); to your wp-config.php.
  • Ensure that your site has the Jetpack Pro plan and has Jetpack Search enabled.
  • Add a Jetpack Search widget to the Search page sidebar.
  • Add a tags filter to the Jetpack Search widget. Also, add a category filter to the Jetpack Search widget.
  • Enter a query into a search widget. Alternatively, navigate to a search page like /?s=privacy.
  • Ensure that you can select a category filter checkbox.
  • Ensure that you can select a tag filter checkbox.

Proposed changelog entry for your changes:

No changelog necessary. Instant Search has not yet been released.

@jsnmoon jsnmoon added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Feature Request [Feature] Search For all things related to Search Instant Search labels Sep 20, 2019
@jsnmoon jsnmoon requested review from gibrown and a team September 20, 2019 20:59
@jsnmoon jsnmoon requested a review from a team as a code owner September 20, 2019 20:59
@jsnmoon jsnmoon self-assigned this Sep 20, 2019
Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM and looks good.

One detail I'm guessing you already know about but just want to confirm that custom taxonomies don't work with this yet. Which is fine for merging this in.

@jsnmoon jsnmoon merged commit 25c4981 into instant-search-master Sep 23, 2019
@jsnmoon jsnmoon deleted the add/instant-search-taxonomy-filter branch September 23, 2019 20:22
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Sep 23, 2019
jsnmoon added a commit that referenced this pull request Oct 23, 2019
* Implement minimal search results and spelling correction (#13365)
* Add filtering display (#13371)
* Fix search result display bugs and make improvements (#13393)
* Add rudimentary support for filtering on post types (#13430)
* Add support for filtering on categories and tags (#13505)
* Add instant search sorting based on the URL (#13377)
* Add support for filtering on dates (#13545)
* Add custom taxonomy filtering (#13605)
* add sort widget (#13614)
* fix many theme incompatibilities (#13602)
* Add infinite scrolling (#13684)
* Add caching to the api requests (#13714)
* Clean up some design bugs/issues (#13721)
* Fix labels for post types when we have them. (#13750)
* Add localization and formatting of all dates (#13748)
* search from any page on the site (#13713)
* Hook up default options (inc. sort) (#13742)
* Add TrainTracks analytics (#13730)
* Create PostTypeIcon component (#13790)
* Upgrade to Preact 10 (#13794)
* Add comments component (#13797)
* Address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Type] Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants