-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant Search: Add custom taxonomy filtering #13605
Merged
jsnmoon
merged 3 commits into
instant-search-master
from
add/instant-search-custom-taxonomy-filtering
Oct 2, 2019
Merged
Instant Search: Add custom taxonomy filtering #13605
jsnmoon
merged 3 commits into
instant-search-master
from
add/instant-search-custom-taxonomy-filtering
Oct 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors how we handle query strings, which affects our API logic.
jsnmoon
added
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
[Feature] Search
For all things related to Search
Instant Search
labels
Sep 30, 2019
jsnmoon
changed the title
Add/instant search custom taxonomy filtering
Instant Search: Add custom taxonomy filtering support
Sep 30, 2019
jsnmoon
changed the title
Instant Search: Add custom taxonomy filtering support
Instant Search: Add custom taxonomy filtering
Sep 30, 2019
bluefuton
reviewed
Oct 1, 2019
bluefuton
reviewed
Oct 1, 2019
gibrown
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some bugginess in the display here for non-English characters, but we have other places we need to fix up filtering display bugs also, so let's get this merged and then fix them all up.
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
labels
Oct 2, 2019
jsnmoon
added a commit
that referenced
this pull request
Oct 23, 2019
* Implement minimal search results and spelling correction (#13365) * Add filtering display (#13371) * Fix search result display bugs and make improvements (#13393) * Add rudimentary support for filtering on post types (#13430) * Add support for filtering on categories and tags (#13505) * Add instant search sorting based on the URL (#13377) * Add support for filtering on dates (#13545) * Add custom taxonomy filtering (#13605) * add sort widget (#13614) * fix many theme incompatibilities (#13602) * Add infinite scrolling (#13684) * Add caching to the api requests (#13714) * Clean up some design bugs/issues (#13721) * Fix labels for post types when we have them. (#13750) * Add localization and formatting of all dates (#13748) * search from any page on the site (#13713) * Hook up default options (inc. sort) (#13742) * Add TrainTracks analytics (#13730) * Create PostTypeIcon component (#13790) * Upgrade to Preact 10 (#13794) * Add comments component (#13797) * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This enables filtering by custom taxonomies using search widget checkboxes.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Yes, this adds support for custom taxonomy filtering to Jetpack Instant Search.
Testing instructions:
define( "JETPACK_SEARCH_PROTOTYPE", true );
to your wp-config.php./?s=privacy
.Configuring a custom taxonomy:
This following code snippet, when added to
wp-content/mu-plugins/functions.php
, will register a custom taxonomy named Speakers.Proposed changelog entry for your changes:
None.