Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg extensions: use @wordpress/base-styles package #14092

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Gutenberg extensions: use @wordpress/base-styles package #14092

merged 4 commits into from
Dec 13, 2019

Conversation

simison
Copy link
Member

@simison simison commented Nov 21, 2019 •
edited
Loading

Switch Gutenberg extensions to use the new @wordpress/base-styles package instead of manually copied over Gutenberg variables.

Changes proposed in this Pull Request:

  • Import variables from @wordpress/base-styles

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Modify; no visible changes

Testing instructions:

  • Build should obviously pass as usual; missing sass variables would break loudly
  • Everything looks as it should; no visible changes

Proposed changelog entry for your changes:

@simison simison added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Nov 21, 2019
@simison simison requested a review from a team November 21, 2019 20:36
@jetpackbot
Copy link

jetpackbot commented Nov 21, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against 03dc053

@simison
Copy link
Member Author

simison commented Nov 21, 2019 •
edited
Loading

Yarn.lock has suspicious changes, something is off... addressed in #14094

@jeherve jeherve added this to the 8.1 milestone Nov 22, 2019
@simison simison mentioned this pull request Nov 22, 2019
Merged
7 tasks
@simison simison force-pushed the update/blocks-use-gutenberg-base-styles-package branch from 8869dca to 63b30e3 Compare November 22, 2019 20:09
@simison
Copy link
Member Author

simison commented Nov 22, 2019

Rebased — ready for review again!

@kraftbj kraftbj force-pushed the update/blocks-use-gutenberg-base-styles-package branch from 63b30e3 to 7524969 Compare December 6, 2019 22:31
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D36403-code before merging this PR. Thank you!

@matticbot
Copy link
Contributor

simison, Your synced wpcom patch D36403-code has been updated.

jeherve
jeherve previously approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 9, 2019
@simison simison force-pushed the update/blocks-use-gutenberg-base-styles-package branch from a38b070 to 3c6dbe1 Compare December 13, 2019 07:44
@simison
Copy link
Member Author

simison commented Dec 13, 2019

Rebased against lastest master. For some reason, yarn.lock wasn't up to date — fixed.

jeherve
jeherve previously approved these changes Dec 13, 2019
View reviewed changes
@matticbot
Copy link
Contributor

simison, Your synced wpcom patch D36403-code has been updated.

@simison
Copy link
Member Author

simison commented Dec 13, 2019

Forced ✅ for wpcom test — Syncing needs some manual work.

jeherve
jeherve previously approved these changes Dec 13, 2019
View reviewed changes
@simison simison force-pushed the update/blocks-use-gutenberg-base-styles-package branch from 0d85205 to 03dc053 Compare December 13, 2019 12:05
@matticbot
Copy link
Contributor

simison, Your synced wpcom patch D36403-code has been updated.

@simison simison merged commit fcf029c into master Dec 13, 2019
@simison simison deleted the update/blocks-use-gutenberg-base-styles-package branch December 13, 2019 12:18
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 13, 2019
@simison
Copy link
Member Author

simison commented Dec 13, 2019

synced in r200692-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@simison simison

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
5 participants
@simison @jetpackbot @matticbot @jeherve @kraftbj