Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn.lock up to date with package.json #14094

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

simison
Copy link
Member

@simison simison commented Nov 21, 2019

#14056 introduced some unrelated yarn.lock changes.

Running yarn in master would always remove these from the lockfile.

Changes proposed in this Pull Request:

  • Sync yarn.lock

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

Testing instructions:

  • Running yarn won't do any changes to lockfile like it does in master

Proposed changelog entry for your changes:

@simison simison added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Build labels Nov 21, 2019
@simison simison requested a review from a team November 21, 2019 22:30
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against 2fde484

@jeherve jeherve added this to the 8.0 milestone Nov 22, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D35813-code before merging this PR. Thank you!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 22, 2019
@simison simison merged commit eb63507 into master Nov 22, 2019
@simison simison deleted the update/fix-yarn-lock branch November 22, 2019 09:44
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants