Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twenty Twenty / Tiled Galleries: fix layout #14224

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Twenty Twenty / Tiled Galleries: fix layout #14224

merged 1 commit into from
Dec 17, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 13, 2019

Changes proposed in this Pull Request:

  • When inserting a Tiled Gallery inside a classic block, you'll notice some layout issues with the Twenty Twenty theme. Those do not apply to the Tiled Gallery block since it uses its own CSS Class.

Testing instructions:

  • Go to Jetpack > Settings > Performance and enable the Image CDN (this turns on the Tiled Galleries module behind the scenes).
  • Go to Posts > Add New
  • Add a Classic Block to the post content.
  • In that classic block, add some text and a tiled gallery
  • Publish post
  • Before the patch is applied, you'll see that the tiled gallery is missing margin and completely to the left in your browser. After the patch is applied, you should see the gallery matching the text's width.

Proposed changelog entry for your changes:

  • Tiled Galleries: fix layout when using a gallery inside a Classic block with the Twenty Twenty theme.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Feature] Theme Tools [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! labels Dec 13, 2019
@jeherve jeherve added this to the 8.1 milestone Dec 13, 2019
@jeherve jeherve requested a review from a team as a code owner December 13, 2019 09:47
@jeherve jeherve self-assigned this Dec 13, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D36712-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Dec 13, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against 9efbb64

scottsweb
scottsweb previously approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@scottsweb scottsweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looks good to me.

@jeherve
Twenty Twenty / Tiled Galleries: fix layout
9efbb64 
When inserting a Tiled Gallery inside a classic block, you'll notice some layout issues with the Twenty Twenty theme. Those do not apply to the Tiled Gallery block since it uses its own CSS Class.
@kraftbj kraftbj added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels Dec 16, 2019
kraftbj
kraftbj approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested before and after patch. Looks dandy.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 16, 2019
@kraftbj kraftbj mentioned this pull request Dec 17, 2019
Closed
@jeherve jeherve merged commit d654550 into master Dec 17, 2019
@jeherve jeherve deleted the fix/twentytwenty-galleries branch December 17, 2019 08:54
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 17, 2019
jeherve added a commit that referenced this pull request Dec 20, 2019
@jeherve
Changelog: add #14224
f4781f7
zinigor added a commit that referenced this pull request Dec 30, 2019
@jeherve @zinigor
Changelog: 8.1 additions (#14166)
fff089c 
* Changelog: 8.1 additions

* Changelog: add #13858

* Changelog: add #13963

* Changelog: add #14174

* Changelog: add #14178

* Changelog: add #14175

* Changelog: add #14192

* Changelog: add #14196

* Changelog: add #14182

* Changelog: add #14218

* Changelog: add #14214

* Changelog: add #13757

* Changelog: add #14190

* Changelog: add #14131

* Changelog: add #14101

* Changelog: add #14203

* Changelog: add #14211

* Changelog: add #14224

* Changelog: add #14230

* Changelog: add #14241

* Changelog: add #14249

* Changelog: add #14264

* Changelog: add #14263

* Changelog: add #14256

* Changelog: add #10189

* Changelog: add #14240

* Changelog: add #14239

Also added some new entries to the testing file.

Co-authored-by: Igor Zinovyev <zinigor@gmail.com>
zinigor added a commit that referenced this pull request Dec 30, 2019
@jeherve @zinigor
Changelog: 8.1 additions (#14166)
d4a7565 
* Changelog: 8.1 additions

* Changelog: add #13858

* Changelog: add #13963

* Changelog: add #14174

* Changelog: add #14178

* Changelog: add #14175

* Changelog: add #14192

* Changelog: add #14196

* Changelog: add #14182

* Changelog: add #14218

* Changelog: add #14214

* Changelog: add #13757

* Changelog: add #14190

* Changelog: add #14131

* Changelog: add #14101

* Changelog: add #14203

* Changelog: add #14211

* Changelog: add #14224

* Changelog: add #14230

* Changelog: add #14241

* Changelog: add #14249

* Changelog: add #14264

* Changelog: add #14263

* Changelog: add #14256

* Changelog: add #10189

* Changelog: add #14240

* Changelog: add #14239

Also added some new entries to the testing file.

Co-authored-by: Igor Zinovyev <zinigor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@scottsweb scottsweb scottsweb left review comments

Assignees

@jeherve jeherve

Labels
[Feature] Theme Tools [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Status] Design Review Complete Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @kraftbj @scottsweb