-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP.com block editor: Exclude WP.com features from Jetpack sites #14230
WP.com block editor: Exclude WP.com features from Jetpack sites #14230
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 14, 2020. |
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
Outdated
Show resolved
Hide resolved
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my question here, this seems to work well in my tests.
I have not tested on Atomic though
All tests great for me, wonderful 👍 |
Oh, hm, I'm not seeing experimental blocks at all (at least, I can't pull up |
That's a component, not a block 🙂 . AFAIK, the only experimental block that is available in Gutenberg right now is the Legacy Widget block. To see it, you need to install the Gutenberg plugin and enable the Widgets experiment: |
public function enqueue_block_assets() { | ||
// These styles are manually copied from //widgets.wp.com/wpcom-block-editor/default.view.css in order to | ||
// improve the performance by avoiding an extra network request to download the CSS file on every page. | ||
wp_add_inline_style( 'wp-block-library', '.has-text-align-justify{text-align:justify;}' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tradeoff here for inlining is that we can't update published styles outside of Jetpack release cycles for any other integration changes.
We could, by just adding another inline style that overrides what's in Jetpack, until the new JP release comes out – certainly not a fun solution, though 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me ✨
Just landed D36841-code so this could be finally merged. @jeherve I dismissed your review with my latest changes using the new bundle names, so this needs your approval again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well for me. 🚢
* Changelog: 8.1 additions * Changelog: add #13858 * Changelog: add #13963 * Changelog: add #14174 * Changelog: add #14178 * Changelog: add #14175 * Changelog: add #14192 * Changelog: add #14196 * Changelog: add #14182 * Changelog: add #14218 * Changelog: add #14214 * Changelog: add #13757 * Changelog: add #14190 * Changelog: add #14131 * Changelog: add #14101 * Changelog: add #14203 * Changelog: add #14211 * Changelog: add #14224 * Changelog: add #14230 * Changelog: add #14241 * Changelog: add #14249 * Changelog: add #14264 * Changelog: add #14263 * Changelog: add #14256 * Changelog: add #10189 * Changelog: add #14240 * Changelog: add #14239 Also added some new entries to the testing file. Co-authored-by: Igor Zinovyev <zinigor@gmail.com>
* Changelog: 8.1 additions * Changelog: add #13858 * Changelog: add #13963 * Changelog: add #14174 * Changelog: add #14178 * Changelog: add #14175 * Changelog: add #14192 * Changelog: add #14196 * Changelog: add #14182 * Changelog: add #14218 * Changelog: add #14214 * Changelog: add #13757 * Changelog: add #14190 * Changelog: add #14131 * Changelog: add #14101 * Changelog: add #14203 * Changelog: add #14211 * Changelog: add #14224 * Changelog: add #14230 * Changelog: add #14241 * Changelog: add #14249 * Changelog: add #14264 * Changelog: add #14263 * Changelog: add #14256 * Changelog: add #10189 * Changelog: add #14240 * Changelog: add #14239 Also added some new entries to the testing file. Co-authored-by: Igor Zinovyev <zinigor@gmail.com>
Changes proposed in this Pull Request:
In order to don't expose some
@automattic/wpcom-block-editor
features to Jetpack sites that are specific of WP.com sites, thecommon
bundle has been split into two new bundlesdefault
andwpcom
in Automattic/wp-calypso#38248.This PRs changes the WordPress.com block editor module to replace the
common
bundle with the newdefault
and to loadwpcom
only when the site is a WP.com site (Atomic).Is this a new feature or does it add/remove features to an existing part of Jetpack?
Changes the existing WordPress.com block editor module.
Testing instructions:
Proposed changelog entry for your changes: