Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calypso-build to 5.1 #14321

Closed
wants to merge 1 commit into from
Closed

Conversation

glendaviesnz
Copy link
Contributor

@glendaviesnz glendaviesnz commented Jan 10, 2020

Updates calypso build to 5.1 which introduces the nullish coalescing operator and optional chaining
plugins. Both of these are now being used in the calypso code base so would be good for them to be an option in the jetpack javascript modules.

Feel free to just close this if there are reasons why we wouldn't want to upgrade the calypso build module at this point.

Changes proposed in this Pull Request:

  • Updates @automattic/calypso-build version in package.json

Testing instructions:

Not sure on the best way to test this - ran all of the build scripts in package.json and nothing seems to be broken.

@glendaviesnz glendaviesnz requested a review from a team January 10, 2020 01:50
@glendaviesnz glendaviesnz self-assigned this Jan 10, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello glendaviesnz! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D37503-code before merging this PR. Thank you!

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 081fcb0

@glendaviesnz
Copy link
Contributor Author

Closing as a duplicate of #14194

@jeherve jeherve deleted the add/optional-chaining branch January 10, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants