Mapbox: query for an API key differently depending on platform

[jeherve]

Changes proposed in this Pull Request:

An alternative to #14440

Testing instructions:

Basically repeat the #14307 tests:

Prerequisites

• Have a Simple, Atomic, and Jetpack test sites ready.
• Make sure none of them has a Mapbox token saved. In that case, before applying this PR, please remove it in the Mapbox Access Token field in the Map block sidebar.

Jetpack

• Open the editor and insert a Map block.
• Make sure the Map block loads in the placeholder state, and asks for a token.
• Provide a token, and make sure the map loads correctly.
• Make sure it's possible to change and remove the token in the Mapbox Access Token field in the block sidebar.
• Save the post and check the front end.
• Make sure the Map block is rendered correctly.
• Update the token in the Mapbox Access Token field in the block sidebar with a random incorrect string.
• Wait a bit for the API call to complete and then make sure the block reverted to the placeholder state, with an "incorrect token" error notice.

Simple

• Apply D38065-code and sandbox the API.
• Open the editor and insert a Map block.
• Make sure the Map block loads without asking for an access token.
• Make sure there is no Mapbox Access Token field in the block sidebar.
• Save the post and check the front end.
• Make sure the Map block is rendered correctly.

Atomic

• Install and activate the Jetpack Beta plugin.
• In wp-admin, navigate to Jetpack -> Jetpack Beta; search for the fix/map-block-missing-api-key-wpcom feature branch, and activate it.
• Repeat the same testing steps for a Simple site (skip the first step).

Proposed changelog entry for your changes:

• N/A

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38067-code before merging this PR. Thank you!

[matticbot]

jeherve, Your synced wpcom patch D38067-code has been updated.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 644066a

[zinigor]

Works properly for me in both Jetpack and DotCom environments, looks good too!

[jeherve]

r202042-wpcom