Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Block: avoid using sprintf to get the local API URL. #14445

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Map Block: avoid using sprintf to get the local API URL. #14445

merged 1 commit into from
Jan 24, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 23, 2020

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Block] Map labels Jan 23, 2020
@jeherve jeherve added this to the 8.2 milestone Jan 23, 2020
@jeherve jeherve requested review from zinigor and a team January 23, 2020 17:36
@jeherve jeherve self-assigned this Jan 23, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38072-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against a6d32f0

zinigor
zinigor approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better, thank you!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 23, 2020
@jeherve jeherve merged commit b37441d into master Jan 24, 2020
@jeherve jeherve deleted the update/mapbox-key-jetpack branch January 24, 2020 09:03
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 24, 2020
@jeherve
Copy link
Member Author

jeherve commented Jan 24, 2020

r202083-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor approved these changes

Assignees

@jeherve jeherve

Labels
[Block] Map Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @jetpackbot @zinigor