Instant Search: Update prototype with overlay design

[jsnmoon]

Changes proposed in this Pull Request:

• New, overlay-oriented design
• Improved integration with the Customizer (plus dark/light themes)
• Added tests, bugfixes, photon support, and accessibility improvements

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• Yes, this is part of the Jetpack Instant Search project: p10gg3-9iP-p2. It has not been publically launched.

Testing instructions:

1. Follow these setup instructions to set up Jetpack Instant Search on your site. Please note that the Jetpack Search widget will need to be added to twice: once to your site sidebar/footer and once to the Jetpack Search Sidebar within the search overlay.

2. Submit a query into your site search input. Ensure that a search overlay appears with your search results.

3. Enter your site's customizer (/wp-admin/customize.php) and navigate to the "Jetpack Search" section. Ensure that changing the settings there take effect on the overlay without a page reload.

4. Try enabling and using filters on the widget in your site's sidebar/footer. Ensure that they behave as expected.

5. Try enabling and using filters on the widget inside the search overlay. Ensure that they behave as expected.

Proposed changelog entry for your changes:

• Implements an overlay-based design for Jetpack Instant Search.

items resolved

[mdbitz]

@gibrown, @jsnmoon

A quick note about Jeremy's feedback, we need to remove the test for site_has_vip_index function that was removed.

jetpack/tests/php/modules/search/test-class.jetpack-search-helpers.php

Line 414 in adc512f

public function test_site_has_vip_index( $expected, $constant = null, $filter = false ) {

Removing it should allow for the tests to pass and we'll be able to approve.

Fixed broken tests and updated the whitelist

[mdbitz]

Thanks for addressing all the feedback 🥇

I'm marking this approved, however I'll rely on @jeherve to see if there is anything special about the WP.com merge as there seems to be a conflict so it can't cleanly create.

[jeherve]

This is not the easiest thing to review, but most of it seems to work at the moment. I have some comments, but nothing blocking in my opinion. This can all be addressed in follow-up PRs.

---

I am also getting those notices:

PHP Notice:  Undefined offset: 1 in wp-content/plugins/jetpack-dev/modules/widgets/search.php on line 643
PHP Notice:  Undefined offset: 1 in wp-content/plugins/jetpack-dev/modules/widgets/search.php on line 650

[jsnmoon]

Thank you for your thorough review, @jeherve! :)

[zinigor]

Deployed changes to package and yarn.lock in r202800-wpcom.

[gibrown]

Thanks @zinigor

FYI, I will be working on the merge to wpcom early next week. It didn't get auto created.

[jeherve]

It didn't get auto created.

That's indeed to be expected right now.

• Fusion doesn't handle PRs that add new files just yet, so that's something you'll need to do manually.
• Composer packages aren't quite running on WordPress.com just yet, so PHP files that rely on packages would fail tests once the diff would be created on WordPress.com.