Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Search: Update prototype with overlay design #14550

Merged
merged 78 commits into from
Feb 12, 2020

Commits on Nov 3, 2019

  1. Instant Search: add label and button to search box (#13875)

    * Add label and button to search box and convert to functional component
    
    * Correct lodash import
    bluefuton authored Nov 3, 2019
    Configuration menu
    Copy the full SHA
    07ee707 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Configuration menu
    Copy the full SHA
    67fa346 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c91e1d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ebd22bc View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Instant Search: Improve accessibility (#13884)

    * Turn statements into sentence fragments
    * Add appropriate landmark roles for elements
    * Set portaled widget as a search form
    * Use ordered list for search results
    jsnmoon authored Nov 5, 2019
    Configuration menu
    Copy the full SHA
    5122ca6 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Configuration menu
    Copy the full SHA
    3fb17ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fbad89 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Instant search: add product result component (#13826)

    * [not verified] Add product search result component
    
    * [not verified] Refactor renderResult into component
    
    * [not verified] Convert SearchResult to stateless functional component
    
    * [not verified] Move comments to new shared component
    
    * [not verified] Move Tracks out to common SearchResult
    
    * [not verified] Request additional fields for product results
    
    * Correct field names and remove ratings for now
    
    * Basic styling of cards with images
    
    * Add price where available
    
    * Read result_format from the query string
    
    * Use ordered list
    
    * Style cleanup
    
    * Minor cleanup
    
    * Remove resultFormat from component state
    
    * SearchResults component cleanup
    
    * Standardise class names
    
    * Validate result format before using as CSS class
    
    * Address review nits
    bluefuton authored Nov 7, 2019
    Configuration menu
    Copy the full SHA
    13715ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c22f71 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. Instant Search: add basic Photon support (#13998)

    * Add PhotonImage component
    
    * Bump default dimensions to 300x300
    
    * Bump asset size limit to 100kb
    bluefuton authored Nov 11, 2019
    Configuration menu
    Copy the full SHA
    f5a4e4a View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Configuration menu
    Copy the full SHA
    f5fe499 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Configuration menu
    Copy the full SHA
    908c215 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Configuration menu
    Copy the full SHA
    de00c33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    33edb51 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Instant Search: add label and button to search box (#13875)

    * Add label and button to search box and convert to functional component
    
    * Correct lodash import
    bluefuton authored and gibrown committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    2802e90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cfad28b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1aa5102 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5133bc7 View commit details
    Browse the repository at this point in the history
  5. Instant Search: Improve accessibility (#13884)

    * Turn statements into sentence fragments
    * Add appropriate landmark roles for elements
    * Set portaled widget as a search form
    * Use ordered list for search results
    jsnmoon authored and gibrown committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    fff93d8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cd1ff44 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    78c63da View commit details
    Browse the repository at this point in the history
  8. Instant search: add product result component (#13826)

    * [not verified] Add product search result component
    
    * [not verified] Refactor renderResult into component
    
    * [not verified] Convert SearchResult to stateless functional component
    
    * [not verified] Move comments to new shared component
    
    * [not verified] Move Tracks out to common SearchResult
    
    * [not verified] Request additional fields for product results
    
    * Correct field names and remove ratings for now
    
    * Basic styling of cards with images
    
    * Add price where available
    
    * Read result_format from the query string
    
    * Use ordered list
    
    * Style cleanup
    
    * Minor cleanup
    
    * Remove resultFormat from component state
    
    * SearchResults component cleanup
    
    * Standardise class names
    
    * Validate result format before using as CSS class
    
    * Address review nits
    bluefuton authored and gibrown committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    30f5d0c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a4438c1 View commit details
    Browse the repository at this point in the history
  10. Instant Search: add basic Photon support (#13998)

    * Add PhotonImage component
    
    * Bump default dimensions to 300x300
    
    * Bump asset size limit to 100kb
    bluefuton authored and gibrown committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    f9203b8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5563cd6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c9fd139 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2e1db00 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    478cd6f View commit details
    Browse the repository at this point in the history
  15. Merge branch 'instant-search-master' of github.com:Automattic/jetpack…

    … into instant-search-master
    gibrown committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    ee28a5b View commit details
    Browse the repository at this point in the history
  16. Instant Search: default to query string in getResults() (#13995)

    * Instant Search: use default values for getting results to avoid duplication
    
    * getResults: default to empty object
    
    Co-Authored-By: Jason Moon <4044428+jsnmoon@users.noreply.github.com>
    bluefuton and jsnmoon authored Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8d0a0d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Instant Search: add search form to main content area (#14142)

    * Split search form out of widget component so it can be reused in the main search area
    
    * Include search form in main content area
    
    * Move sort wrapper into component and improve class name
    
    * Give sort component a more sensible name
    
    * Keep search form in place when there are no results
    
    * Just return null when there isn't a query
    
    * Combine pagination conditionals into one clause
    
    Co-Authored-By: Jason Moon <4044428+jsnmoon@users.noreply.github.com>
    
    * Drop SearchResultsEmpty component
    
    * Tidy pagination logic
    
    * Pass all props down to SearchForm
    bluefuton authored Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3523d2e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Instant Search: add filter icon toggle (#14176)

    * Add filter icon
    
    * Simple show/hide toggle
    
    * Make it an interactive element
    
    * Add aria-hidden to gridicon
    bluefuton authored Dec 10, 2019
    Configuration menu
    Copy the full SHA
    895626c View commit details
    Browse the repository at this point in the history
  2. Instant Search: Improve UX for offline network state (#14189)

    * Fix invisible space breaking date layout
    * Restore info Gridicon
    * Add warning notice component
    * Check offline state before using short term cache
    * Inject cache state variables into response data
    * Show “cached results” notice when the user is offline
    * Catch connectivity error and notify the user
    * Show correct number of results when offline
    * Hide load more button when offline
    * Wrap new copy in translation calls
    jsnmoon authored Dec 10, 2019
    Configuration menu
    Copy the full SHA
    6f07d1f View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Instant Search: try using an overlay (#14205)

    * Try the overlay (Hotel California edition)
    
    * Add button to close overlay
    
    * Always display search form attached to search results
    
    * Add a note about portaled search inputs
    
    * Use showResults instead of using showOverlay value
    
    * Add a large z-index and increase opacity
    
    * Simplify SearchApp, trigger overlay on input focus
    
    * Disable WordPress Search for Instant Search
    
    * Revert "Disable WordPress Search for Instant Search"
    
    This reverts commit 65b7dcb.
    
    * Add jetpack namespace to translation
    
    Co-Authored-By: Jason Moon <4044428+jsnmoon@users.noreply.github.com>
    
    * Use the searchInputSelector
    
    Co-Authored-By: Jason Moon <4044428+jsnmoon@users.noreply.github.com>
    
    * Add missing quote
    bluefuton authored Dec 16, 2019
    Configuration menu
    Copy the full SHA
    b481984 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Instant Search: setup preact-testing-library (#13950)

    * Add preact-testing-library
    
    * Rebase
    
    * Add instant-search dir to existing Jest config
    
    * First attempt at test
    
    * Tidying
    
    * Create 'yarn test-search'
    
    * Remove package-lock.json
    
    * Add jsx pragma
    
    * [not verified]
    
    * Enable test and added dependency docblocks
    
    * Remove rogue Slack package
    bluefuton authored Dec 19, 2019
    Configuration menu
    Copy the full SHA
    49d06e8 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Configuration menu
    Copy the full SHA
    8be3b44 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    336413e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Configuration menu
    Copy the full SHA
    1af22dc View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Instant Search: trigger overlay on submit (#14248)

    * Remove focus event listeners
    
    * Respond to submit rather than focus
    
    * Allow enter key to launch overlay
    
    * Reflect widget search input changes in query string
    
    * Close overlay with Esc key
    
    * Reflect query string change in search widget input
    
    * Make sure the sort options match
    
    * Try grabbing focus in getResults
    
    * Remove focus code
    
    * Remove grabFocus (no longer in use)
    
    * Handle overlay escape key with useEffect rather than converting to Component
    
    * Move closeOnEscapeKey out of render
    bluefuton authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    07095b2 View commit details
    Browse the repository at this point in the history
  2. Instant Search: Add sidebar widget area (#14283)

    * Fix linting violations by changing `date` invocations to `gmdate`
    * Add sidebar widget area
    * Add SearchSidebar component
    * Integrate SearchSidebar into SearchResults
    * Implement Overlay animation from design prototype
    jsnmoon authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    6806c69 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Instant Search: refactor search php for the different experiences (#1…

    …4284)
    
    - refactor php to extract all instant search code
    - add customizer for the overlay
    - add running the search query on the backend to display filters when the page loads.
    gibrown authored Jan 9, 2020
    Configuration menu
    Copy the full SHA
    584d61a View commit details
    Browse the repository at this point in the history
  2. Instant Search: fix Esc key behaviour (#14312)

    * Instant Search: prevent Esc from opening overlay
    
    * Use isVisible rather than shouldShowOverlay
    bluefuton authored Jan 9, 2020
    Configuration menu
    Copy the full SHA
    9a315b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Instant Search: Add search filtering inside overlay (#14319)

    * Add SearchFilters above SearchSidebar
    * Instant Search: Add a button to clear applied filters (#14324)
      * Add function to clear filter query values
      * Fix class names for elements in SearchFilter
      * Add “Clear Filters” button
    jsnmoon authored Jan 14, 2020
    Configuration menu
    Copy the full SHA
    5116f88 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Instant search: introduce overlay from right (#14339)

    * Introduce overlay from right
    
    * Updating overlay offset values
    
    - Changes units from `vh` to `vw`.
    - Updates value from `200` to `100`, as [mentioned here](#14320 (comment)).
    
    Co-authored-by: Filipe Varela <keoshi@keoshi.com>
    bluefuton and keoshi authored Jan 15, 2020
    Configuration menu
    Copy the full SHA
    dc7176d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Configuration menu
    Copy the full SHA
    bc801fb View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Instant Search: Use widgets inside overlay for filtering (#14374)

    * Add search filter portaling inside overlay sidebar
    * Update readme with new testing instructions
    jsnmoon authored Jan 17, 2020
    Configuration menu
    Copy the full SHA
    fcc6447 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Instant Search: update overlay styles (#14379)

    * Make search input as large as possible
    
    * Remove opinionated styles
    
    * Add more margin to the filter icon
    
    * Add screen reader text for the search box
    
    * Change order of date element
    
    * Change date position
    
    * Clean up styles
    
    * Update style for comments in search results
    
    * Fix name of CSS property
    
    * Make search result title class more specific
    
    Also reorders styles
    
    See: #14379 (comment)
    
    * Remove extra screen reader text
    
    See: #14379 (comment)
    keoshi authored Jan 20, 2020
    Configuration menu
    Copy the full SHA
    2db1ef0 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Configuration menu
    Copy the full SHA
    8dd97ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d155a7b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Instant Search: Integrate customizer options (#14427)

    * Integrate customizer options for search overlay
    * Fix infinite scroll functionality
    jsnmoon authored Jan 22, 2020
    Configuration menu
    Copy the full SHA
    92a6169 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a065ba8 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Instant Search: add dark theme styles (#14429)

    * Update styles for base overlay
    * Update styles for search results
    keoshi authored and gibrown committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    1dcecc0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a5ac6a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9bc1bd View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Configuration menu
    Copy the full SHA
    f42480e View commit details
    Browse the repository at this point in the history
  2. Instant Search: Move focus into overlay input (#14477)

    * Move focus to and from overlay
    * Use useRef and event listeners for focus shifting
    
    Co-authored-by: Chris R <chris@bluefuton.com>
    jsnmoon and bluefuton authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    7c3e207 View commit details
    Browse the repository at this point in the history
  3. Instant Search: use taxonomy name rather than slug for filters (#14437)

    * Instant Search: use taxonomy name rather than slug
    
    * Fix display of category filters
    
    * Update buildFilterObject()
    bluefuton authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    607dbb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. Configuration menu
    Copy the full SHA
    fbb8c6f View commit details
    Browse the repository at this point in the history
  2. Instant Search: switch to use .slug_slash_name for displaying custom …

    …taxonomies, tags and categories (#14492)
    
    * Switch to use .slug_slash_name for taxonomies, tags and categories
    
    * Use slug in the query, and name for display
    bluefuton authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    a7a8fe3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b22aeb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    603677e View commit details
    Browse the repository at this point in the history
  5. Instant Search : Update mobile structure (#14423)

    * Add cross gridicon
    
    * Replace close button label by a gridicon
    
    * Change position of close button
    
    * Update z-index stacking order
    
    Prevents sidebar to be in front of the close button
    
    * Reorder CSS properties
    
    * Add medium break point at 768px
    
    * Add mobile styles for filters popover
    
    * Change how transparency is set on the overlay
    
    * Update break-small to break-medium
    
    * Add styles for smaller close button on mobile devices
    
    * Add arrow element to popover
    
    * Remove styles that are out of place
    
    Given the markup has changed in #14477, these styles need to be applied elsewhere
    
    * Update search results styling
    
    * Add popover styles
    
    * Update filter icon margins
    
    * Show sidebar filters up to 768px
    
    See: #14423 (review)
    
    * Bring up the opacity on the arrow border
    
    * Reduce side padding on small screens
    
    * Move margin to label span instead of select element
    keoshi authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    409d420 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Instant Search: Restore initial href upon closing overlay (#14518)

    * Restore initial href when closing overlay
    * Fix incorrect inline style removal
    jsnmoon authored Jan 30, 2020
    Configuration menu
    Copy the full SHA
    efabb3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eab1d5e View commit details
    Browse the repository at this point in the history
  3. Search: Front end search filters open overlay (#14448)

    - Refactor filter display for front end
    - Remove rendering filters in the overlay
    - Front end filters open the overlay
    gibrown authored Jan 30, 2020
    Configuration menu
    Copy the full SHA
    2448d2a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. Instant search: add "powered by Jetpack" message (#14519)

    * Show JetpackColophon when setting is activated
    
    * Translate text
    
    * Added logo and styles
    
    * Style tweaks
    
    * Link to jetpack.com/search
    
    * Add colophon to mobile filters
    
    * Margin tweak
    bluefuton authored Jan 31, 2020
    Configuration menu
    Copy the full SHA
    95535d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c1eb19 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Instant Search: Clear search and filter queries when necessary (#14533)

    * Clear search and filter queries if necessary
    * Improve initialHref restoration function
    * Create a separate handler for popstate events
    jsnmoon authored Feb 1, 2020
    Configuration menu
    Copy the full SHA
    1febfbd View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    3f6b70c View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    6e1835e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b11afef View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Instant Search: Update list of widgets passed to JS client (#14596)

    * Only return widgets inside the overlay sidebar
    * Remove overlay sidebar membership check in JS
    jsnmoon authored Feb 10, 2020
    Configuration menu
    Copy the full SHA
    e7ff6cb View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Configuration menu
    Copy the full SHA
    51fb046 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f434c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9d64ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cfc93e2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    855921c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e67c601 View commit details
    Browse the repository at this point in the history