Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revue Block: Update Input Placeholders Color and Default Text #14888

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Revue Block: Update Input Placeholders Color and Default Text #14888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba981b
Update Revue placeholders color and default text
Copons Mar 4, 2020
2eca699
Also updates placeholders in the SSR
Copons Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extensions/blocks/revue/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ export default {
},
emailPlaceholder: {
type: 'string',
default: __( 'Your email address…', 'jetpack' ),
default: __( 'Enter your email address', 'jetpack' ),
},
firstNameLabel: {
type: 'string',
default: __( 'First name', 'jetpack' ),
},
firstNamePlaceholder: {
type: 'string',
default: __( 'First name… (Optional)', 'jetpack' ),
default: __( 'Enter your first name', 'jetpack' ),
},
firstNameShow: {
type: 'boolean',
Expand All @@ -38,7 +38,7 @@ export default {
},
lastNamePlaceholder: {
type: 'string',
default: __( 'Last name… (Optional)', 'jetpack' ),
default: __( 'Enter your last name', 'jetpack' ),
},
lastNameShow: {
type: 'boolean',
Expand Down
5 changes: 5 additions & 0 deletions extensions/blocks/revue/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,16 @@
.components-base-control {
margin-bottom: 16px;
}

.components-base-control__label {
display: block;
}

.components-placeholder__learn-more {
margin-top: 1em;
}

.components-text-control__input {
color: #72777c;
}
}
6 changes: 3 additions & 3 deletions extensions/blocks/revue/revue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,12 @@ function jetpack_get_revue_attribute( $attribute, $attributes ) {
$default_attributes = array(
'text' => __( 'Subscribe', 'jetpack' ),
'emailLabel' => __( 'Email address', 'jetpack' ),
'emailPlaceholder' => __( 'Your email address…', 'jetpack' ),
'emailPlaceholder' => __( 'Enter your email address', 'jetpack' ),
'firstNameLabel' => __( 'First name', 'jetpack' ),
'firstNamePlaceholder' => __( 'First name… (Optional)', 'jetpack' ),
'firstNamePlaceholder' => __( 'Enter your first name', 'jetpack' ),
'firstNameShow' => true,
'lastNameLabel' => __( 'Last name', 'jetpack' ),
'lastNamePlaceholder' => __( 'Last name… (Optional)', 'jetpack' ),
'lastNamePlaceholder' => __( 'Enter your last name', 'jetpack' ),
'lastNameShow' => true,
);

Expand Down