Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revue Block: Update Input Placeholders Color and Default Text #14888

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Revue Block: Update Input Placeholders Color and Default Text #14888

merged 2 commits into from
Mar 5, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Mar 4, 2020

Changes proposed in this Pull Request:

  • Update the Revue block placeholders color in the editor when the field is not being edited in order to make it look more like a placeholder than the value of an input field (which it technically is).
    The chosen color is the same used by the Contact Form block for the same purpose.

  • Update the Revue block placeholders default texts, removing the unnecessary "(Optional)" text, and making them more similar to the Mailchimp block placeholders.
    Mailchimp uses a simple "Enter your email" text, but for Revue I've chosen to use "Enter your email address", as the field label is "Email address", and just "email" felt a bit awkward to me.
    cc @davemart-in if you have any thoughts on improving the input placeholders here

Screenshot 2020-03-04 at 15 26 08

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • p58i-8Du-p2

Testing instructions:

  • Insert a Revue block.
  • Make sure the new default placeholders are the same as in the screenshot.
  • Make sure the input fields placeholders color is gray when the field is not selected, and black when editing it.

Proposed changelog entry for your changes:

  • Revue block: update input placeholders color and default text

@Copons Copons added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Revue labels Mar 4, 2020
@Copons Copons requested a review from a team March 4, 2020 21:47
@Copons Copons requested a review from a team as a code owner March 4, 2020 21:47
@Copons Copons self-assigned this Mar 4, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello Copons! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39893-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Mar 4, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 2eca699

@davemart-in davemart-in self-requested a review March 5, 2020 12:49
davemart-in
davemart-in previously approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🛳

scruffian
scruffian previously requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@scruffian scruffian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We also need to update the default labels in the server side render:

jetpack/extensions/blocks/revue/revue.php

Line 220 in 64db1ea

'firstNamePlaceholder' => __( 'First name… (Optional)', 'jetpack' ),

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 5, 2020
@matticbot
Copy link
Contributor

Copons, Your synced wpcom patch D39893-code has been updated.

@Copons Copons added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 5, 2020
@Copons Copons requested a review from scruffian March 5, 2020 17:37
jeherve
jeherve approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 5, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 5, 2020
@Copons Copons dismissed scruffian’s stale review March 5, 2020 18:19

Fixed as requested

@Copons Copons merged commit e14653e into master Mar 5, 2020
@Copons Copons deleted the update/revue-block-placeholders branch March 5, 2020 18:20
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 5, 2020
@Copons
Copy link
Contributor Author

Copons commented Mar 5, 2020

r203929-wpcom

jeherve added a commit that referenced this pull request Mar 20, 2020
@jeherve
Changelog: add #14888
ac8d68e
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@davemart-in davemart-in davemart-in left review comments

@scruffian scruffian Awaiting requested review from scruffian

Assignees

@Copons Copons

Labels
[Block] Revue [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Copons @matticbot @jetpackbot @scruffian @jeherve @davemart-in