Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Update copy for Pro Plan #15123

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

gibrown
Copy link
Member

@gibrown gibrown commented Mar 25, 2020

A few updates to the copy for Search module to reflect instant search. Removing references to ES and using the new instant search and filtering language.

Some of these I am not even sure they still get displayed, but I did some searching in the repo to find them.

I've also fixed the plans grid which was coming from the wp.com api.

@gibrown gibrown added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Feature] Search For all things related to Search Instant Search labels Mar 25, 2020
@gibrown gibrown added this to the InstantSearchLaunch milestone Mar 25, 2020
@gibrown gibrown requested review from keoshi and AnnaMag March 25, 2020 21:14
@gibrown gibrown requested a review from a team as a code owner March 25, 2020 21:14
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello gibrown! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40860-code before merging this PR. Thank you!

Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yes, yes! Ship it.

@gibrown gibrown merged commit 252c305 into add/search-plan Mar 26, 2020
@gibrown gibrown deleted the update/pro-search-copy branch March 26, 2020 15:19
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 26, 2020
gibrown added a commit that referenced this pull request Mar 30, 2020
* Search: Add Search plan to wp-admin Plans/My-Plans pages (#15011)
* Add Instant Search feature gate
* Add Jetpack Search to the Plans page
* Instant Search: Add support in glance and performance sections (#15043)
* Search: Add instant search auto config (#15026)
* Significant refactoring of Plans pages, especially for Backups
* Update the copy for search module. (#15123)
* Search: Add search plan to my-plans page (#15095)
* Search: Add pricing and tier information to Plans page (#15125)
* Search: Fix search plan detection (#15156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants