Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add search plan to dashboard #15153

Merged
merged 11 commits into from
Mar 30, 2020
Merged

Search: Add search plan to dashboard #15153

merged 11 commits into from
Mar 30, 2020

Conversation

gibrown
Copy link
Member

@gibrown gibrown commented Mar 27, 2020

This merges the changes to the JP dashboard that allow management of the new Search Plan.

What is missing:

  • APIs to trigger the auto-config Search: Add autoconfig apis #15105
  • The full end to end purchase flow with all the links won't work because Search plans work only in the development environment of Calypso

Testing Instructions:

jsnmoon and others added 7 commits March 17, 2020 13:16
* Add Instant Search feature gate
* Add Jetpack Search to the Plans page
* Add Search plan constants
* Tweak At-A-Glance Search Component
* Move Search and Media to top of Performance tab
* Enable toggling Instant Search via Performance tab
* Check for Instant Search eligibility w/ plan class
* Add Search plan to the developer menu
* Improve copy in Performance settings

Co-authored-by: Greg Ichneumon Brown <greg@automattic.com>
Co-authored-by: Filipe Varela <keoshi@keoshi.com>
* Update markup for the product card
* Update styles
Method to auto config the search widgets based on registered post types and taxonomies
Co-authored-by: Jason Moon <jason.moon@automattic.com>
* Add handling for pricing and tier APIs
* Use a unified loading state for single feature products
@gibrown gibrown added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Feature] Search For all things related to Search Instant Search labels Mar 27, 2020
@gibrown gibrown added this to the InstantSearchLaunch milestone Mar 27, 2020
@gibrown gibrown requested review from jeherve and mdbitz March 27, 2020 18:59
@gibrown gibrown requested a review from a team as a code owner March 27, 2020 18:59
@gibrown gibrown self-assigned this Mar 27, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello gibrown! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D41012-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Mar 27, 2020

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 611eb20

@mdbitz
Copy link
Contributor

mdbitz commented Mar 27, 2020

Did a brief code review of the PR and didn't see any immediate concerns that jumped out. The big item on this is going to be testing and regressions to Plans

  1. Any impact to Backups plan? prevously purchase was specific to backups but now is split.
  2. Legacy Jetpack Search functionality - is it still functional for business plans and instant search is only for users with a paid search plan? (Have to confirm what desired behavior is)
  3. Review of each plan type to ensure desired behavior (unavailable/available)
  4. Auto Configure - as mentioned not current connected needs manual execution to test.
  5. UX display of Plans, customize and front end
  6. Record counts, as plans are based off counts would be good to spot check this for various content ranges

Misc Notes:
__ in jsx files is the translate function from calypso which doesn't utilize the domain property and has versions for singular and plural

@gibrown gibrown modified the milestones: InstantSearchLaunch, 8.4 Mar 27, 2020
@jsnmoon
Copy link
Member

jsnmoon commented Mar 27, 2020

  1. Any impact to Backups plan? previously purchase was specific to backups but now is split. @mdbitz

We had to substantially refactor parts of Backups components in the Plans page. There shouldn't be any changes to its behavior, however.

  1. Legacy Jetpack Search functionality - is it still functional for business plans and instant search is only for users with a paid search plan? (Have to confirm what desired behavior is) @mdbitz

As I understand it, the Business/Professional plan will retain the ability to enable the Jetpack Search module. However, it will not be able to enable the new Instant Search feature.

  1. Review of each plan type to ensure desired behavior (unavailable/available) @mdbitz

👍 The only noticeable difference should be the ability to enable Instant Search with an active Jetpack Search product purchase.

* Add Search product purchase detection
* Remove Instant Search feature gate for Plans page
* Simplify Plans page by only using SiteProducts
* Remove mention of the enhanced search for biz plan
* Use new PurchasedProductCard component
* Update copy
* Fix malformed and missorted imports
* Add preliminary support for Search product option
* Use consistent naming for selector function
* Don’t return anything for useEffect function
* Bypass search support check in the JetpackPlan class
@mdbitz
Copy link
Contributor

mdbitz commented Mar 29, 2020

Testing Continues :)

I'm seeing the new Instant Search toggle that is only "enable-able" (lol) if the search plan is added to the site.

Quick Question

On the Dashboard under Performance should there be similar details about instant search?

Screen Shot 2020-03-29 at 9 36 57 AM

@mdbitz
Copy link
Contributor

mdbitz commented Mar 29, 2020

Screen Shot 2020-03-29 at 9 48 18 AM

I think the "Which backup option is best for me?" link should now be in the Backup plans card.

Copy link
Contributor

@mdbitz mdbitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as Approved.

No concerns at a code level, This needs copious levels of testing on plans and to ensure no regression to search. I've done a walk though on my site for different scenarios ( different plans, content sizes, etc) without any blockers being identified.

@gibrown gibrown merged commit a5ec8c3 into master Mar 30, 2020
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 30, 2020
jeherve added a commit that referenced this pull request Mar 31, 2020
jeherve added a commit that referenced this pull request Mar 31, 2020
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
@jsnmoon jsnmoon deleted the add/search-plan branch February 15, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants