-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Ensure that production builds are valid ES5 #17127
Conversation
Scheduled Jetpack release: November 10, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17127 Thank you for the great PR description! When this PR is ready for review, please apply the |
Might try |
How about running it through
|
Yeah, so running through (I realize that that means that we might have to make sure we only run validation after a production build; but running it unconditionally from |
No, it's working right actually 🤔 But validation is at the wrong script.
Notice how we don't have a
Probably we should add a
|
Ohh you're right! Looks like I didn't read that |
Added validation to the other production builds. The funny part is, those pass validation now, whereas the production build for extensions doesn't 😅
|
Do you remember the PR that added more modules to the transpile list? Well, that's not happening here. Take a look at these lines: ( and delete them :) ) jetpack/webpack.config.extensions.js Lines 115 to 123 in 42f04ea
and delete these as well since we aren't using this variable anymore jetpack/webpack.config.extensions.js Lines 93 to 95 in 42f04ea
That is already fixed in |
Great spot, thanks @david-szabo97! Fix coming right up 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth waiting until #16845 gets merged so we can add validation to all builds at once?
Yeah, makes sense 👍 |
a611330
to
b2f8b37
Compare
Caution: This PR has changes that must be merged to WordPress.com |
@jeherve Since #16845 apparently requires some more work, can we proceed with this one (and maybe add ES5 validation for the extensions build to #16845)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we proceed with this one
Yeah, sounds like a plan!
Fixes #13693.
Changes proposed in this Pull Request:
Add ES5 validation to production builds.
Inspired by Automattic/wp-calypso#36596.
Can't currently add it to the
extension
build, since there are non-ES5 constructs in them.Jetpack product discussion
Code quality.
Does this pull request change what data or activity we track or use?
Nah.
Testing instructions:
Run
yarn build-production
, and verify that eslint doesn't report any errors at the end.Proposed changelog entry for your changes:
Add ES5 validation to production builds.