-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Remove lazy-images ES5 validation #17561
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17561 This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, no need to ask Crew for review via GH. We have a list of all 'Needs Review' PRs to review. It helps to keep our individual GH notifications clean.
Testing failures are the unrelated ones that started plaguing us yesterday seeming from something Core changed. This may need a rebase once we figure that out. |
Co-authored-by: Brandon Kraft <public@brandonkraft.com>
r215636-wpcom |
yarn build-production-packages
currently fails due to the recently introduced ES5 validation (#17127). (That PR probably went green in CI since it was last rebased before #17489 was merged.) This PR removes the latter, until the issues reported here are fixed.Changes proposed in this Pull Request:
Remove ES5 validation from
build-production-packages
command.Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Verify that CI goes green. Locally, verify that the following passes without errors: