Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Remove lazy-images ES5 validation #17561

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Oct 21, 2020

yarn build-production-packages currently fails due to the recently introduced ES5 validation (#17127). (That PR probably went green in CI since it was last rebased before #17489 was merged.) This PR removes the latter, until the issues reported here are fixed.

Changes proposed in this Pull Request:

Remove ES5 validation from build-production-packages command.

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Verify that CI goes green. Locally, verify that the following passes without errors:

`yarn build-production-packages

@ockham ockham added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] High labels Oct 21, 2020
@ockham ockham requested a review from a team October 21, 2020 12:13
@ockham ockham self-assigned this Oct 21, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello ockham! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D51563-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

jetpackbot commented Oct 21, 2020

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes
⚠️

pre-commit hook was skipped for one or more commits

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17561

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ce09f7f

@kraftbj kraftbj removed the request for review from a team October 21, 2020 12:32
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 21, 2020
@kraftbj kraftbj added this to the 9.1 milestone Oct 21, 2020
kraftbj
kraftbj previously approved these changes Oct 21, 2020
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, no need to ask Crew for review via GH. We have a list of all 'Needs Review' PRs to review. It helps to keep our individual GH notifications clean.

@kraftbj
Copy link
Contributor

kraftbj commented Oct 21, 2020

Testing failures are the unrelated ones that started plaguing us yesterday seeming from something Core changed. This may need a rebase once we figure that out.

Co-authored-by: Brandon Kraft <public@brandonkraft.com>
@kraftbj kraftbj merged commit f07b148 into master Oct 21, 2020
@kraftbj kraftbj deleted the remove/lazy-images-es5-validation branch October 21, 2020 22:22
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 21, 2020
@kraftbj
Copy link
Contributor

kraftbj commented Oct 21, 2020

r215636-wpcom

anomiex added a commit that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants