Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin] Backup: Update/upgrade button link #21590

Merged
merged 4 commits into from
Nov 4, 2021
Merged

[Plugin] Backup: Update/upgrade button link #21590

merged 4 commits into from
Nov 4, 2021

Conversation

nunyvega
Copy link

Update upgrade button link to point to the checkout page.

Changes proposed in this Pull Request:

Currently, the Upgrade button on the Jetpack Backup plugin points to:
https://jetpack.com/upgrade/backup/?site=[your-site], where the user can then click on Back up your site to pay for Jetpack Backup.
This PR changes the target of the button and it now points directly to the checkout page. It is currently adding the Jetpack Backup Daily plan.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1- On a new site, add the Jetpack Backup plugin
2- go to the plugin admin page on your site and click on the upgrade button
3- Confirm that you're taken directly to the checkout page and that Jetpack Backup Daily is added to the cart.

Alvaro Vega added 2 commits October 29, 2021 18:45
[Plugin] Backup: Update upgrade link target
6ea26ad 
This PR changes the target link of the upgrade button
to point directly to the checkout page.
[Plugin] Backup: update upgrade button target
6788418 
This minor change updates the redirect URL of the
upgrade button to point to the checkout page.
@nunyvega nunyvega added [Status] Needs Team Review [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. labels Oct 29, 2021
@nunyvega nunyvega requested a review from jwebbdev October 29, 2021 17:07
@nunyvega nunyvega self-assigned this Oct 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Backup plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 29, 2021.

@nunyvega
Copy link
Author

@jwebbdev one question on this, do we always want to checkout the backup daily plan?

@jwebbdev jwebbdev added this to the backup/1.1.0 milestone Oct 29, 2021
@jwebbdev jwebbdev added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Oct 29, 2021
@jwebbdev
Copy link
Contributor

@jwebbdev one question on this, do we always want to checkout the backup daily plan?

Yeah, that's what we'll do currently. We may have more information / links inside the plugin to other plans and pricing, but that's the one we'll focus on for this.

@jwebbdev
Copy link
Contributor

Since this is marked as a minor change it now wants it to be 1.1.0-alpha instead of 1.0.1-alpha. You can use tools/project-version.sh -u 1.1.0-alpha plugins/backup to update it.

jwebbdev
jwebbdev approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@jwebbdev jwebbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunyvega nunyvega merged commit 42492d1 into master Nov 4, 2021
@nunyvega nunyvega deleted the update/upgrade-link-target branch November 4, 2021 08:06
davidlonjon added a commit that referenced this pull request Nov 5, 2021
@davidlonjon
Merge branch 'master' into fix/boost-and-general-linting-formatting
2c5a1b3 
# By Brad Jorsch (2) and others
# Via GitHub
* master:
  Boost: Fix the official name to the JavaScript word reference (#21638)
  tools: Allow extra spaces in next-version tags (#21647)
  Publicize: always add an alt text to Open Graph Images (#21520)
  js-tools: Add missing eslint plugin dep (#21642)
  * Deactivate SSO in e2e environment (#21644)
  Publicize: Handling feature availability information and upgrading (#21567)
  Nav Unification: Remove `preferred-view` param after update (#21632)
  [Plugin] Backup: Update/upgrade button link (#21590)

# Conflicts:
#	projects/plugins/boost/app/assets/src/js/pages/settings/sections/Modules.svelte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwebbdev jwebbdev jwebbdev approved these changes

Assignees

@nunyvega nunyvega

Labels
[Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
backup/1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nunyvega @jwebbdev